fix: skip TestUnhandledRejection errors with TARGET_CLOSED_ERROR_MESSAGE

fix: don't catch timeout errors in `expect` matchers

Author: uid11

autotests/tests/switchingPagesForResponses.ts

@@ -63,6 +63,7 @@ test(
 
     await expect(
       numberOfSentRequests === numberOfCaughtResponses ||
+        numberOfSentRequests === numberOfCaughtResponses + 2 ||
         numberOfSentRequests === numberOfCaughtResponses + 1 ||
         numberOfSentRequests === numberOfCaughtResponses - 1,
       `almost all responses were caught (${numberOfCaughtResponses} of ${numberOfSentRequests})`,

src/ApiRoute.ts

@@ -13,14 +13,12 @@ export abstract class ApiRoute<
   /**
    * Request type of API route.
    */
-  // eslint-disable-next-line @typescript-eslint/naming-convention
-  declare readonly __REQUEST_KEY: SomeRequest;
+  declare readonly Request: SomeRequest;
 
   /**
    * Response type of API route.
    */
-  // eslint-disable-next-line @typescript-eslint/naming-convention
-  declare readonly __RESPONSE_KEY: SomeResponse;
+  declare readonly Response: SomeResponse;
 
   /**
    * Returns `true`, if the request body is in JSON format.

src/WebSocketRoute.ts

@@ -16,14 +16,12 @@ export abstract class WebSocketRoute<
   /**
    * Request type of WebSocket route.
    */
-  // eslint-disable-next-line @typescript-eslint/naming-convention
-  declare readonly __REQUEST_KEY: SomeRequest;
+  declare readonly Request: SomeRequest;
 
   /**
    * Response type of WebSocket route.
    */
-  // eslint-disable-next-line @typescript-eslint/naming-convention
-  declare readonly __RESPONSE_KEY: SomeResponse;
+  declare readonly Response: SomeResponse;
 
   /**
    * Returns `true`, if the request body is in JSON format.

src/constants/internal.ts

@@ -63,7 +63,7 @@ export {
   TMP_DIRECTORY_PATH,
 } from './paths';
 /** @internal */
-export {TEST_ENDED_ERROR_MESSAGE} from './playwright';
+export {TARGET_CLOSED_ERROR_MESSAGE, TEST_ENDED_ERROR_MESSAGE} from './playwright';
 /** @internal */
 export {RESOLVED_PROMISE} from './promise';
 /** @internal */

src/constants/playwright.ts

@@ -1,3 +1,9 @@
+/**
+ * Playwright error message for already closed target (`TargetClosedError`).
+ * @internal
+ */
+export const TARGET_CLOSED_ERROR_MESSAGE = 'Target page, context or browser has been closed';
+
 /**
  * Playwright error message for already ended test.
  * @internal

src/createClientFunction.ts

@@ -1,4 +1,4 @@
-import {TEST_ENDED_ERROR_MESSAGE} from './constants/internal';
+import {TARGET_CLOSED_ERROR_MESSAGE, TEST_ENDED_ERROR_MESSAGE} from './constants/internal';
 import {getTestIdleTimeout} from './context/testIdleTimeout';
 import {E2edError} from './utils/error';
 import {setCustomInspectOnFunction} from './utils/fn';
@@ -13,7 +13,6 @@ import type {ClientFunction} from './types/internal';
 type Options = Readonly<{name?: string; retries?: number; timeout?: number}>;
 
 const contextErrorMessage = 'Execution context was destroyed';
-const targetErrorMessage = 'Target page, context or browser has been closed';
 
 /**
  * Creates a client function.
@@ -48,7 +47,7 @@ export const createClientFunction = <Args extends readonly unknown[], Result>(
 
         if (
           errorString.includes(contextErrorMessage) ||
-          errorString.includes(targetErrorMessage) ||
+          errorString.includes(TARGET_CLOSED_ERROR_MESSAGE) ||
           errorString.includes(TEST_ENDED_ERROR_MESSAGE)
         ) {
           await page.waitForLoadState();
@@ -58,7 +57,7 @@ export const createClientFunction = <Args extends readonly unknown[], Result>(
 
             if (
               suberrorString.includes(contextErrorMessage) ||
-              suberrorString.includes(targetErrorMessage) ||
+              suberrorString.includes(TARGET_CLOSED_ERROR_MESSAGE) ||
               suberrorString.includes(TEST_ENDED_ERROR_MESSAGE)
             ) {
               return new Promise(() => {});
@@ -80,7 +79,7 @@ export const createClientFunction = <Args extends readonly unknown[], Result>(
 
                 if (
                   suberrorString.includes(contextErrorMessage) ||
-                  suberrorString.includes(targetErrorMessage) ||
+                  suberrorString.includes(TARGET_CLOSED_ERROR_MESSAGE) ||
                   suberrorString.includes(TEST_ENDED_ERROR_MESSAGE)
                 ) {
                   return new Promise(() => {});

src/utils/expect/createExpectMethod.ts

@@ -92,11 +92,7 @@ export const createExpectMethod = (
       }
 
       return runAssertion(this.actualValue);
-    }).catch((error: Error) => ({
-      actualValue: this.actualValue,
-      description: this.description,
-      error,
-    }));
+    });
 
     return assertionPromise.then(({actualValue, additionalLogFields, error}) => {
       const logMessage = `Assert: ${this.description}`;

src/utils/getGlobalErrorHandler.ts

@@ -1,3 +1,5 @@
+import {TARGET_CLOSED_ERROR_MESSAGE, TEST_ENDED_ERROR_MESSAGE} from '../constants/internal';
+
 import {E2edError} from './error';
 import {writeGlobalError} from './fs';
 import {writeLogsToFile} from './generalLog';
@@ -11,8 +13,18 @@ import type {GlobalErrorType} from '../types/internal';
 export const getGlobalErrorHandler =
   (type: GlobalErrorType) =>
   (cause: unknown): void => {
-    const error = new E2edError(`Caught ${type}`, {cause});
+    try {
+      const error = new E2edError(`Caught ${type}`, {cause});
+      const errorString = error.toString();
+
+      if (
+        errorString.includes(TARGET_CLOSED_ERROR_MESSAGE) ||
+        errorString.includes(TEST_ENDED_ERROR_MESSAGE)
+      ) {
+        return;
+      }
 
-    void writeGlobalError(error.toString()).catch(() => {});
-    void writeLogsToFile().catch(() => {});
+      void writeGlobalError(errorString).catch(() => {});
+      void writeLogsToFile().catch(() => {});
+    } catch {}
   };

src/utils/report/client/chooseTestRun.ts

@@ -38,7 +38,12 @@ export function chooseTestRun(runHash: RunHash): void {
 
   const {testRunDetailsElementsByHash} = reportClientState;
 
-  const previousTestRunDetailsElement = e2edRightColumnContainer.firstElementChild as HTMLElement;
+  const previousTestRunDetailsElement =
+    e2edRightColumnContainer.firstElementChild as HTMLElement | null;
+
+  if (!previousTestRunDetailsElement) {
+    return;
+  }
 
   if (
     !(previousHash in testRunDetailsElementsByHash) &&

src/utils/report/client/render/renderApiStatistics.ts

@@ -34,11 +34,11 @@ export function renderApiStatistics({apiStatistics, hash}: Options): SafeHtml {
       let pageDuration = 0;
       const pageItems: SafeHtml[] = [];
 
-      for (const [url, {count, duration}] of Object.entries(byUrl)) {
+      for (const [url, {count, duration}] of Object.entries(byUrl) as ObjectEntries<typeof byUrl>) {
         pageCount += count;
         pageDuration += duration;
 
-        pageItems.push(renderApiStatisticsItem({count, duration, name: url}));
+        pageItems.push(renderApiStatisticsItem({count, duration, name: url, url}));
       }
 
       items.push(