add tests to ensure no regression for bug

Author: jonathanrcross

tests/test_base.py

@@ -1,9 +1,13 @@
-import pytest
-import tests.common as common
-import nomad
 import os
+
+import mock
+import pytest
+import requests
 import responses
 
+import nomad
+import tests.common as common
+
 
 def test_base_region_qs():
     n = nomad.Nomad(host=common.IP, port=common.NOMAD_PORT, verify=False, token=common.NOMAD_TOKEN, region="random")
@@ -46,11 +50,33 @@ def test_base_delete_connection_error():
         j = n.job.deregister_job("example")
 
 
-def test_base_raise_exception_():
-    n = nomad.Nomad(
-        host="162.16.10.102", port=common.NOMAD_PORT, timeout=0.001, verify=False)
-    with pytest.raises(nomad.api.exceptions.BaseNomadException):
-        j = n.job.deregister_job("example")
+@mock.patch("nomad.api.base.requests.Session")
+def test_base_raise_exception_not_requests_response_object(mock_requests):
+    mock_requests().delete.side_effect = [requests.RequestException()]
+
+    try:
+        n = nomad.Nomad(
+            host="162.16.10.102",
+            port=common.NOMAD_PORT,
+            timeout=0.001,
+            verify=False
+        )
+
+        _ = n.job.deregister_job("example")
+
+    except nomad.api.exceptions.BaseNomadException as err:
+        assert hasattr(err, "text") is False
+        assert isinstance(err.nomad_resp, requests.RequestException)
+        assert "raised due" in str(err)
+
+
+def test_base_raise_exception_is_requests_response_object(nomad_setup):
+    try:
+        _ = nomad_setup.job.deregister_job("example")
+    except nomad.api.exceptions.BaseNomadException as err:
+        assert hasattr(err, "text") is True
+        assert isinstance(err.nomad_resp, requests.Response)
+        assert "raised with" in str(err)
 
 
 @pytest.mark.skipif(tuple(int(i) for i in os.environ.get("NOMAD_VERSION").split(".")) < (0, 7, 0), reason="Nomad dispatch not supported")