Test --insecure-tls-config flag

(cherry picked from commit 8a12767)

Author: mangelajo

packages/jumpstarter-cli-admin/jumpstarter_cli_admin/create_test.py

@@ -18,6 +18,7 @@
 from jumpstarter.config.client import ClientConfigV1Alpha1, ClientConfigV1Alpha1Drivers
 from jumpstarter.config.common import ObjectMeta
 from jumpstarter.config.exporter import ExporterConfigV1Alpha1
+from jumpstarter.config.tls import TLSConfigV1Alpha1
 
 # Generate a random client name
 CLIENT_NAME = uuid.uuid4().hex
@@ -83,6 +84,15 @@
     drivers=ClientConfigV1Alpha1Drivers(allow=[], unsafe=True),
 )
 
+INSECURE_TLS_CLIENT_CONFIG = ClientConfigV1Alpha1(
+    alias=CLIENT_NAME,
+    metadata=ObjectMeta(namespace="default", name=CLIENT_NAME),
+    endpoint=CLIENT_ENDPOINT,
+    token=CLIENT_TOKEN,
+    tls=TLSConfigV1Alpha1(insecure=True),
+    drivers=ClientConfigV1Alpha1Drivers(allow=[], unsafe=True),
+)
+
 
 @pytest.mark.anyio
 @patch.object(ClientConfigV1Alpha1, "save")
@@ -103,6 +113,33 @@ async def test_create_client(
     mock_save_client.assert_not_called()
     mock_save_client.reset_mock()
 
+    # Insecure TLS config is returned
+    mock_get_client_config.return_value = INSECURE_TLS_CLIENT_CONFIG
+
+    # Save with prompts accept insecure = Y, save = Y, unsafe = Y
+    result = await runner.invoke(create, ["client", "--insecure-tls-config", CLIENT_NAME], input="Y\nY\nY\n")
+    assert result.exit_code == 0
+    assert "Client configuration successfully saved" in result.output
+    mock_save_client.assert_called_once_with(INSECURE_TLS_CLIENT_CONFIG, None)
+    mock_save_client.reset_mock()
+
+    # Save no interactive and insecure tls
+    result = await runner.invoke(
+        create, ["client", "--insecure-tls-config", "--unsafe", "--save", "--nointeractive", CLIENT_NAME]
+    )
+    assert result.exit_code == 0
+    assert "Client configuration successfully saved" in result.output
+    mock_save_client.assert_called_once_with(INSECURE_TLS_CLIENT_CONFIG, None)
+    mock_save_client.reset_mock()
+
+    # Insecure TLS config is returned
+    mock_get_client_config.return_value = INSECURE_TLS_CLIENT_CONFIG
+
+    # Save with prompts accept insecure = N
+    result = await runner.invoke(create, ["client", "--insecure-tls-config", CLIENT_NAME], input="n\n")
+    assert result.exit_code == 1
+    assert "Aborted" in result.output
+
     # Unsafe client config is returned
     mock_get_client_config.return_value = UNSAFE_CLIENT_CONFIG
 
@@ -222,6 +259,14 @@ async def test_create_client(
     token=EXPORTER_TOKEN,
 )
 
+INSECURE_TLS_EXPORTER_CONFIG = ExporterConfigV1Alpha1(
+    alias=EXPORTER_NAME,
+    metadata=ObjectMeta(namespace="default", name=EXPORTER_NAME),
+    endpoint=EXPORTER_ENDPOINT,
+    token=EXPORTER_TOKEN,
+    tls=TLSConfigV1Alpha1(insecure=True),
+)
+
 
 @pytest.mark.anyio
 @patch.object(ExporterConfigV1Alpha1, "save")
@@ -242,6 +287,32 @@ async def test_create_exporter(
     save_exporter_mock.assert_not_called()
     save_exporter_mock.reset_mock()
 
+    # Insecure TLS config is returned
+    _get_exporter_config_mock.return_value = INSECURE_TLS_EXPORTER_CONFIG
+    # Save with prompts accept insecure = Y, save = Y
+    result = await runner.invoke(create, ["exporter", "--insecure-tls-config", EXPORTER_NAME], input="Y\nY\n")
+    assert result.exit_code == 0
+    assert "Exporter configuration successfully saved" in result.output
+    save_exporter_mock.assert_called_once_with(INSECURE_TLS_EXPORTER_CONFIG, None)
+    save_exporter_mock.reset_mock()
+
+    _get_exporter_config_mock.return_value = INSECURE_TLS_EXPORTER_CONFIG
+    # Save with prompts accept no interactive
+    result = await runner.invoke(
+        create, ["exporter", "--insecure-tls-config", "--nointeractive", "--save", EXPORTER_NAME]
+    )
+    assert result.exit_code == 0
+    assert "Exporter configuration successfully saved" in result.output
+    save_exporter_mock.assert_called_once_with(INSECURE_TLS_EXPORTER_CONFIG, None)
+    save_exporter_mock.reset_mock()
+
+    # Insecure TLS config is returned
+    _get_exporter_config_mock.return_value = INSECURE_TLS_EXPORTER_CONFIG
+    # Save with prompts accept insecure = N
+    result = await runner.invoke(create, ["exporter", "--insecure-tls-config", EXPORTER_NAME], input="n\n")
+    assert result.exit_code == 1
+    assert "Aborted" in result.output
+
     # Save with prompts
     result = await runner.invoke(create, ["exporter", EXPORTER_NAME], input="Y\n")
     assert result.exit_code == 0

packages/jumpstarter-cli-admin/jumpstarter_cli_admin/import_res_test.py

@@ -13,6 +13,7 @@
 from jumpstarter.config.client import ClientConfigV1Alpha1, ClientConfigV1Alpha1Drivers
 from jumpstarter.config.common import ObjectMeta
 from jumpstarter.config.exporter import ExporterConfigV1Alpha1
+from jumpstarter.config.tls import TLSConfigV1Alpha1
 
 # Generate a random client name
 CLIENT_NAME = uuid.uuid4().hex
@@ -34,6 +35,14 @@
     token=CLIENT_TOKEN,
     drivers=ClientConfigV1Alpha1Drivers(allow=[DRIVER_NAME], unsafe=False),
 )
+INSECURE_TLS_CLIENT_CONFIG = ClientConfigV1Alpha1(
+    alias=CLIENT_NAME,
+    metadata=ObjectMeta(namespace="default", name=CLIENT_NAME),
+    endpoint=CLIENT_ENDPOINT,
+    token=CLIENT_TOKEN,
+    tls=TLSConfigV1Alpha1(insecure=True),
+    drivers=ClientConfigV1Alpha1Drivers(allow=[], unsafe=True),
+)
 
 
 @pytest.mark.anyio
@@ -60,6 +69,34 @@ async def test_import_client(_load_kube_config_mock, get_client_config_mock: Asy
     save_client_config_mock.assert_called_once_with(UNSAFE_CLIENT_CONFIG, None)
     save_client_config_mock.reset_mock()
 
+    # Test insecure TLS config
+    get_client_config_mock.return_value = INSECURE_TLS_CLIENT_CONFIG
+
+    # Save with prompts accept insecure = Y
+    result = await runner.invoke(import_res, ["client", CLIENT_NAME, "--insecure-tls-config"], input="Y\nY\n")
+    assert result.exit_code == 0
+    assert "Client configuration successfully saved" in result.output
+    save_client_config_mock.assert_called_once_with(INSECURE_TLS_CLIENT_CONFIG, None)
+    save_client_config_mock.reset_mock()
+
+   # Save with prompts no interactive prompts and insecure tls cert
+    result = await runner.invoke(import_res, ["client", CLIENT_NAME, "--nointeractive", "--insecure-tls-config"])
+    assert result.exit_code == 0
+    assert "Client configuration successfully saved" in result.output
+    save_client_config_mock.assert_called_once_with(INSECURE_TLS_CLIENT_CONFIG, None)
+    save_client_config_mock.reset_mock()
+
+
+    # Save with prompts accept insecure = N
+    result = await runner.invoke(import_res, ["client", CLIENT_NAME, "--insecure-tls-config"], input="n\n")
+    assert result.exit_code == 1
+    assert "Aborted" in result.output
+    save_client_config_mock.assert_not_called()
+    save_client_config_mock.reset_mock()
+
+    # Reset mock for subsequent tests
+    get_client_config_mock.return_value = UNSAFE_CLIENT_CONFIG
+
     # Save with custom out file
     out = f"/tmp/{CLIENT_NAME}.yaml"
     result = await runner.invoke(import_res, ["client", CLIENT_NAME, "--unsafe", "--out", out])
@@ -108,6 +145,13 @@ async def test_import_client(_load_kube_config_mock, get_client_config_mock: Asy
     endpoint=EXPORTER_ENDPOINT,
     token=EXPORTER_TOKEN,
 )
+INSECURE_TLS_EXPORTER_CONFIG = ExporterConfigV1Alpha1(
+    alias=EXPORTER_NAME,
+    metadata=ObjectMeta(namespace="default", name=EXPORTER_NAME),
+    endpoint=EXPORTER_ENDPOINT,
+    token=EXPORTER_TOKEN,
+    tls=TLSConfigV1Alpha1(insecure=True),
+)
 
 
 @pytest.mark.anyio
@@ -124,6 +168,26 @@ async def test_import_exporter(_load_kube_config_mock, _get_exporter_config_mock
     save_exporter_config_mock.assert_called_with(EXPORTER_CONFIG, None)
     save_exporter_config_mock.reset_mock()
 
+    # Test insecure TLS config
+    _get_exporter_config_mock.return_value = INSECURE_TLS_EXPORTER_CONFIG
+
+    # Save with prompts accept insecure = Y
+    result = await runner.invoke(import_res, ["exporter", EXPORTER_NAME, "--insecure-tls-config"], input="Y\n")
+    assert result.exit_code == 0
+    assert "Exporter configuration successfully saved" in result.output
+    save_exporter_config_mock.assert_called_once_with(INSECURE_TLS_EXPORTER_CONFIG, None)
+    save_exporter_config_mock.reset_mock()
+
+    # Save with prompts accept insecure = N
+    result = await runner.invoke(import_res, ["exporter", EXPORTER_NAME, "--insecure-tls-config"], input="n\n")
+    assert result.exit_code == 1
+    assert "Aborted" in result.output
+    save_exporter_config_mock.assert_not_called()
+    save_exporter_config_mock.reset_mock()
+
+    # Reset mock for subsequent tests
+    _get_exporter_config_mock.return_value = EXPORTER_CONFIG
+
     # Save with custom out file
     out = f"/tmp/{EXPORTER_NAME}.yaml"
     result = await runner.invoke(import_res, ["exporter", EXPORTER_NAME, "--out", out])