Merge pull request #368 from jumpstarter-dev/fix-lazy-grpc-keepalive

NickCao · web-flow · commit 886f21aff2d1 · 2025-03-21T09:04:20.000-04:00
Don't stop grpc keepalives after 5 pings
diff --git a/packages/jumpstarter/jumpstarter/common/grpc.py b/packages/jumpstarter/jumpstarter/common/grpc.py
@@ -49,7 +49,7 @@ def _override_default_grpc_options(grpc_options: dict[str, str | int] | None) ->
         # we keep a low keepalive time to avoid idle timeouts on cloud load balancers
         ("grpc.keepalive_time_ms", 20000),
         ("grpc.keepalive_timeout_ms", 5000),
-        ("grpc.http2.max_pings_without_data", 5),
+        ("grpc.http2.max_pings_without_data", 0),
         ("grpc.keepalive_permit_without_calls", 1),
     )
     options = dict(defaults)

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ def _override_default_grpc_options(grpc_options: dict[str, str \| int] \| None) ->`
`49`	`49`	`# we keep a low keepalive time to avoid idle timeouts on cloud load balancers`
`50`	`50`	`("grpc.keepalive_time_ms", 20000),`
`51`	`51`	`("grpc.keepalive_timeout_ms", 5000),`
`52`		`- ("grpc.http2.max_pings_without_data", 5),`
	`52`	`+ ("grpc.http2.max_pings_without_data", 0),`
`53`	`53`	`("grpc.keepalive_permit_without_calls", 1),`
`54`	`54`	`)`
`55`	`55`	`options = dict(defaults)`