Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

Commit e2bcc59

Browse files
committed
jumpstarter-driver-flashers: Fix additional review comments
1 parent 615f5fb commit e2bcc59

3 files changed

Lines changed: 5 additions & 3 deletions

File tree

packages/jumpstarter-driver-flashers/jumpstarter_driver_flashers/client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def flash(
8282
skip_exporter_http = False
8383
image_url = ""
8484
operator_scheme = None
85-
if path.startswith(("http://")) and not force_exporter_http:
85+
if path.startswith("http://") and not force_exporter_http:
8686
# busybox can handle the http from a remote directly, unless target is isolated
8787
image_url = path
8888
skip_exporter_http = True
@@ -346,7 +346,7 @@ def _upload_artifact(self, storage, path: PathBuf, operator: Operator):
346346
if storage.exists(filename):
347347
# TODO: check hash for existing files
348348
self.logger.info(f"Artifact {filename} already exists in storage, skipping")
349-
storage.write_from_path(path, operator=operator)
349+
storage.write_from_path(filename, path, operator=operator)
350350

351351
@contextmanager
352352
def _services_up(self):

packages/jumpstarter-driver-flashers/oci_bundles/build_bundle.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
# oras login quay.io -u mangelajo
44

5+
set -e
6+
57
FLASHER_OCI_CONTAINER="${1:-quay.io/jumpstarter-dev/jumpstarter-flasher-test:latest}"
68
BUNDLE_FILES=${2:-"./test/"}
79

packages/jumpstarter-driver-flashers/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[project]
22
name = "jumpstarter-driver-flashers"
33
dynamic = ["version", "urls"]
4-
description = "Add your description here"
4+
description = "Jumpstarter software defined flasher driver"
55
readme = "README.md"
66
license = { text = "Apache-2.0" }
77
authors = [

0 commit comments

Comments
 (0)