client: compare lease selectors

when a lease is already is set in the env (JMP_LEASE), the requested selector will be ignored,
even if it does not match the existing lease.

Instead of silently using the env lease, warn and create a new lease

Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
(cherry picked from commit b076954)

Author: bennyz

packages/jumpstarter/jumpstarter/client/lease.py

@@ -85,7 +85,18 @@ async def request_async(self):
         :raises TimeoutError: if lease is not ready after timeout
         """
         if self.name:
-            logger.debug("Using existing lease %s", self.name)
+            logger.debug("using existing lease via env or flag %s", self.name)
+            existing_lease = await self.get()
+            if existing_lease.selector != self.selector:
+                logger.warning(
+                    "Existing lease from env or flag %s has selector '%s' but requested selector is '%s'. "
+                    "Creating a new lease instead",
+                    self.name,
+                    existing_lease.selector,
+                    self.selector,
+                )
+                self.name = None
+                await self._create()
         else:
             await self._create()
         return await self._acquire()