Skip to content

Commit e4e436b

Browse files
authored
Merge pull request #201 from inas-sirhan/fix/jobs-filter-select-empty-value
Fix Jobs filter crash: empty Select.Item value
2 parents 591df3e + 842c5db commit e4e436b

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

ui/src/components/jobs/JobList.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -208,14 +208,14 @@ export function JobList({ initialFilters, compact = false, onJobClick }: JobList
208208
<div className="space-y-1">
209209
<label className="text-sm font-medium">Status</label>
210210
<Select
211-
value={draftFilters.status || ''}
212-
onValueChange={(value) => setDraftFilters({ ...draftFilters, status: value || undefined })}
211+
value={draftFilters.status || 'all'}
212+
onValueChange={(value) => setDraftFilters({ ...draftFilters, status: value === 'all' ? undefined : value })}
213213
>
214214
<SelectTrigger>
215215
<SelectValue placeholder="All statuses" />
216216
</SelectTrigger>
217217
<SelectContent>
218-
<SelectItem value="">All</SelectItem>
218+
<SelectItem value="all">All</SelectItem>
219219
<SelectItem value="New">New</SelectItem>
220220
<SelectItem value="Queued">Queued</SelectItem>
221221
<SelectItem value="Running">Running</SelectItem>

0 commit comments

Comments
 (0)