Merge pull request #55 from keboola/jirka-add-max-length-to-snflk

Add constants for max length in snflk

Author: jirkasemmler

src/Definition/Redshift.php

@@ -166,7 +166,7 @@ private function validateLength(string $type, $length = null): void
                     $valid = false;
                     break;
                 }
-                if (isset($parts[1]) && ((int) $parts[1] > (int) $parts[0] || (int) $parts[1] > 37)) {
+                if (isset($parts[1]) && ((int) $parts[1] > 37 || (int) $parts[1] > (int) $parts[0])) {
                     $valid = false;
                     break;
                 }
@@ -175,7 +175,6 @@ private function validateLength(string $type, $length = null): void
             case 'CHARACTER VARYING':
             case 'TEXT':
             case 'NVARCHAR':
-            case 'TEXT':
                 if (is_null($length) || $length === '') {
                     break;
                 }

src/Definition/Snowflake.php

@@ -75,6 +75,9 @@ class Snowflake extends Common
         self::TYPE_VARBINARY,
     ];
 
+    public const MAX_VARCHAR_LENGTH = 16777216;
+    public const MAX_VARBINARY_LENGTH = 8388608;
+
     /**
      * Snowflake constructor.
      *
@@ -207,7 +210,7 @@ private function validateLength(string $type, $length = null): void
                     $valid = false;
                     break;
                 }
-                if (isset($parts[1]) && ((int) $parts[1] > (int) $parts[0] || (int) $parts[1] > 38)) {
+                if (isset($parts[1]) && ((int) $parts[1] > 38 || (int) $parts[1] > (int) $parts[0])) {
                     $valid = false;
                     break;
                 }
@@ -224,7 +227,7 @@ private function validateLength(string $type, $length = null): void
                     $valid = false;
                     break;
                 }
-                if ((int) $length <= 0 || (int) $length > 16_777_216) {
+                if ((int) $length <= 0 || (int) $length > self::MAX_VARCHAR_LENGTH) {
                     $valid = false;
                     break;
                 }
@@ -256,7 +259,7 @@ private function validateLength(string $type, $length = null): void
                     $valid = false;
                     break;
                 }
-                if ((int) $length < 1 || (int) $length > 8_388_608) {
+                if ((int) $length < 1 || (int) $length > self::MAX_VARBINARY_LENGTH) {
                     $valid = false;
                     break;
                 }