Skip to content

Commit a2dbaf7

Browse files
committed
Drop default value for snflk
1 parent 8c35631 commit a2dbaf7

2 files changed

Lines changed: 5 additions & 9 deletions

File tree

src/Definition/Snowflake.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,12 +119,8 @@ public function getSQLDefinition(): string
119119
if (!$this->isNullable()) {
120120
$definition .= ' NOT NULL';
121121
}
122-
123-
if ($this->getDefault() !== null) {
124-
$definition .= ' DEFAULT ' . $this->getDefault();
125-
}
126-
127122
return $definition;
123+
// TODO default value by basetype
128124
}
129125

130126
/**

tests/SnowflakeDatatypeTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -115,11 +115,11 @@ public function testSqlDefinition(): void
115115
$definition = new Snowflake('NUMERIC', ['length' => '10,10', 'nullable' => false]);
116116
$this->assertSame($definition->getSQLDefinition(), 'NUMERIC (10,10) NOT NULL');
117117

118-
$definition = new Snowflake('NUMERIC', ['length' => '10,10', 'nullable' => false, 'default' => '10']);
119-
$this->assertSame($definition->getSQLDefinition(), 'NUMERIC (10,10) NOT NULL DEFAULT 10');
118+
$definition = new Snowflake('NUMERIC', ['length' => '10,10', 'nullable' => false]);
119+
$this->assertSame($definition->getSQLDefinition(), 'NUMERIC (10,10) NOT NULL');
120120

121-
$definition = new Snowflake('NUMERIC', ['length' => '10,10', 'nullable' => true, 'default' => '10']);
122-
$this->assertSame($definition->getSQLDefinition(), 'NUMERIC (10,10) DEFAULT 10');
121+
$definition = new Snowflake('NUMERIC', ['length' => '10,10', 'nullable' => true]);
122+
$this->assertSame($definition->getSQLDefinition(), 'NUMERIC (10,10)');
123123

124124
$definition = new Snowflake('TIMESTAMP_TZ', ['length' => '0']);
125125
$this->assertSame($definition->getSQLDefinition(), 'TIMESTAMP_TZ (0)');

0 commit comments

Comments
 (0)