Merge pull request #62 from keboola/zajca-kbc-2791

KBC-2791 add default for SNFLK

Author: zajca

src/Definition/Snowflake.php

@@ -101,6 +101,9 @@ public function __construct(string $type, array $options = [])
         if ($diff !== []) {
             throw new InvalidOptionException("Option '{$diff[0]}' not supported");
         }
+        if (array_key_exists('default', $options) && $options['default'] === '') {
+            unset($options['default']);
+        }
         parent::__construct($type, $options);
     }
 
@@ -121,8 +124,10 @@ public function getSQLDefinition(): string
         if (!$this->isNullable()) {
             $definition .= ' NOT NULL';
         }
+        if ($this->getDefault() !== null) {
+            $definition .= ' DEFAULT ' . $this->getDefault();
+        }
         return $definition;
-        // TODO default value by basetype
     }
 
     /**

tests/SnowflakeDatatypeTest.php

@@ -121,6 +121,15 @@ public function testSqlDefinition(): void
         $definition = new Snowflake('NUMERIC', ['length' => '10,10', 'nullable' => true]);
         $this->assertSame($definition->getSQLDefinition(), 'NUMERIC (10,10)');
 
+        $definition = new Snowflake('NUMERIC', ['length' => '10,10', 'nullable' => true, 'default' => '10']);
+        $this->assertSame($definition->getSQLDefinition(), 'NUMERIC (10,10) DEFAULT 10');
+
+        $definition = new Snowflake('NUMERIC', ['length' => '10,10', 'nullable' => true, 'default' => '']);
+        $this->assertSame($definition->getSQLDefinition(), 'NUMERIC (10,10)');
+
+        $definition = new Snowflake('VARCHAR', ['length' => '10', 'nullable' => true, 'default' => '\'\'']);
+        $this->assertSame($definition->getSQLDefinition(), 'VARCHAR (10) DEFAULT \'\'');
+
         $definition = new Snowflake('TIMESTAMP_TZ', ['length' => '0']);
         $this->assertSame($definition->getSQLDefinition(), 'TIMESTAMP_TZ (0)');