Merge pull request #57 from keboola/jirka-exasol-default-length-for-numeric

KBC-2782 numeric default length has decimal part

Author: jirkasemmler

src/Definition/Exasol.php

@@ -57,7 +57,7 @@ class Exasol extends Common
     public const TYPE_REAL = 'REAL'; // REAL = DOUBLE PRECISION
 
     // default lengths for different kinds of types. Used max values
-    public const MAX_DECIMAL_LENGTH = '36,36'; // max is 36.36, default 18,0
+    public const MAX_DECIMAL_LENGTH = '36,18'; // max is 36 digits, lets split them, default 18,0
     public const MAX_CHAR_LENGTH = 2000;
     public const MAX_VARCHAR_LENGTH = 2_000_000;
     public const MAX_GEOMETRY_LENGTH = 4_294_967_295; // max value

tests/ExasolDatatypeTest.php

@@ -135,11 +135,11 @@ public function testSqlDefinition(string $type, array $options, string $expected
     public function expectedSqlDefinitions(): array
     {
         return [
-            'DECIMAL' => ['DECIMAL', [], 'DECIMAL (36,36)'],
-            'DEC' => ['DEC', [], 'DEC (36,36)'],
+            'DECIMAL' => ['DECIMAL', [], 'DECIMAL (36,18)'],
+            'DEC' => ['DEC', [], 'DEC (36,18)'],
             'NUMBER' => ['NUMBER', [], 'DOUBLE PRECISION'],
             'NUMBER WITH LENGTH' => ['NUMBER', ['length' => '20,20'], 'NUMBER (20,20)'],
-            'NUMERIC' => ['NUMERIC', [], 'NUMERIC (36,36)'],
+            'NUMERIC' => ['NUMERIC', [], 'NUMERIC (36,18)'],
 
             'CHAR' => ['CHAR', [], 'CHAR (2000)'],
             'NCHAR' => ['NCHAR', [], 'NCHAR (2000)'],