Skip to content

Commit 381064c

Browse files
committed
fix: address Copilot review comments on PR #286
- Use require_once instead of include_once in loader.php for fail-fast - Fix array indentation in SessionTest.php - Fix docblock formatting in SnowflakeDatabaseReflectionTest and SnowflakeTableQueryBuilderTest
1 parent 21ce77b commit 381064c

3 files changed

Lines changed: 14 additions & 28 deletions

File tree

tests/Functional/Bigquery/Connection/SessionTest.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,15 @@ public function testCreateSession(): void
2929
$this->bqClient->query(
3030
'SELECT 1',
3131
[
32-
'configuration' => [
33-
'query' => [
34-
'connectionProperties' => [
35-
'key' => 'session_id',
36-
'value' => $session->getSessionId(),
32+
'configuration' => [
33+
'query' => [
34+
'connectionProperties' => [
35+
'key' => 'session_id',
36+
'value' => $session->getSessionId(),
37+
],
38+
],
3739
],
3840
],
39-
],
40-
],
4141
),
4242
);
4343

tests/Functional/Snowflake/Database/SnowflakeDatabaseReflectionTest.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@ class SnowflakeDatabaseReflectionTest extends SnowflakeBaseCase
1717
protected function setUp(): void
1818
{
1919
$this->markTestSkipped('Test won\'t work as testing user has not such high privileges.');
20-
/**
21-
* @phpstan-ignore-next-line
22-
*/
20+
/** @phpstan-ignore-next-line */
2321
parent::setUp();
2422
$this->setUpUser(self::USERNAME);
2523
$this->setUpRole(self::ROLE);

tests/Unit/Table/Snowflake/SnowflakeTableQueryBuilderTest.php

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -143,49 +143,37 @@ public static function provideGetColumnDefinitionUpdate(): Generator
143143
yield 'drop default' => [
144144
new Snowflake('NUMERIC', ['length' => '12,8', 'nullable' => true, 'default' => '10']),
145145
new Snowflake('NUMERIC', ['length' => '12,8', 'nullable' => true, 'default' => null]),
146-
/**
147-
* @lang Snowflake
148-
*/
146+
/** @lang Snowflake */
149147
'ALTER TABLE "testDb"."testTable" MODIFY COLUMN "testColumn" DROP DEFAULT',
150148
];
151149
yield 'add nullable' => [
152150
new Snowflake('NUMERIC', ['length' => '12,8', 'nullable' => false, 'default' => '']),
153151
new Snowflake('NUMERIC', ['length' => '12,8', 'nullable' => true, 'default' => '']),
154-
/**
155-
* @lang Snowflake
156-
*/
152+
/** @lang Snowflake */
157153
'ALTER TABLE "testDb"."testTable" MODIFY COLUMN "testColumn" DROP NOT NULL',
158154
];
159155
yield 'drop nullable' => [
160156
new Snowflake('NUMERIC', ['length' => '12,8', 'nullable' => true, 'default' => '']),
161157
new Snowflake('NUMERIC', ['length' => '12,8', 'nullable' => false, 'default' => '']),
162-
/**
163-
* @lang Snowflake
164-
*/
158+
/** @lang Snowflake */
165159
'ALTER TABLE "testDb"."testTable" MODIFY COLUMN "testColumn" SET NOT NULL',
166160
];
167161
yield 'increase length of text column' => [
168162
new Snowflake('VARCHAR', ['length' => '12', 'nullable' => true, 'default' => '']),
169163
new Snowflake('VARCHAR', ['length' => '38', 'nullable' => true, 'default' => '']),
170-
/**
171-
* @lang Snowflake
172-
*/
164+
/** @lang Snowflake */
173165
'ALTER TABLE "testDb"."testTable" MODIFY COLUMN "testColumn" SET DATA TYPE VARCHAR(38)',
174166
];
175167
yield 'increase precision of numeric column' => [
176168
new Snowflake('NUMERIC', ['length' => '12,8', 'nullable' => true, 'default' => '']),
177169
new Snowflake('NUMERIC', ['length' => '14,8', 'nullable' => true, 'default' => '']),
178-
/**
179-
* @lang Snowflake
180-
*/
170+
/** @lang Snowflake */
181171
'ALTER TABLE "testDb"."testTable" MODIFY COLUMN "testColumn" SET DATA TYPE NUMERIC(14, 8)',
182172
];
183173
yield 'full set of changes (increase precision, drop nullable, drop default)' => [
184174
new Snowflake('NUMERIC', ['length' => '12,8', 'nullable' => true, 'default' => 'grunbread']),
185175
new Snowflake('NUMERIC', ['length' => '14,8', 'nullable' => false, 'default' => '']),
186-
/**
187-
* @lang Snowflake
188-
*/
176+
/** @lang Snowflake */
189177
'ALTER TABLE "testDb"."testTable" MODIFY COLUMN "testColumn" DROP DEFAULT, '
190178
. 'COLUMN "testColumn" SET NOT NULL, COLUMN "testColumn" SET DATA TYPE NUMERIC(14, 8)',
191179
];

0 commit comments

Comments
 (0)