Skip to content

Commit 6d9a81a

Browse files
martinsifraclaude
andcommitted
refactor: Storage API client MergeRequest::updateMergeRequest accepts array with data
- DMD-1081 - updateMergeRequest methods accepts array with data instead of single values Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 50e7cd9 commit 6d9a81a

1 file changed

Lines changed: 25 additions & 10 deletions

File tree

src/Keboola/StorageApi/Client.php

Lines changed: 25 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -978,7 +978,15 @@ public function pullTableToBranch(string $tableId): string
978978
}
979979

980980
/**
981-
* @param array{branchFromId: int, branchIntoId: int, title: string, description: ?string} $data
981+
* @param array{
982+
* branchFromId: int,
983+
* branchIntoId: int,
984+
* title: string,
985+
* description?: ?string,
986+
* externalId?: ?string,
987+
* autoMergeStrategy?: ?string,
988+
* autoMergeAt?: ?string
989+
* } $data
982990
* @return int - created MR id
983991
*/
984992
public function createMergeRequest(array $data): int
@@ -1005,15 +1013,22 @@ public function getMergeRequest(int $mergeRequestId): array
10051013
return $mrDetail;
10061014
}
10071015

1008-
public function updateMergeRequest(int $mergeRequestId, string $title, ?string $description = null): array
1016+
/**
1017+
* @param array{
1018+
* title: string,
1019+
* description?: ?string,
1020+
* externalId?: ?string,
1021+
* autoMergeStrategy?: ?string,
1022+
* autoMergeAt?: ?string
1023+
* } $data
1024+
* @return array mrData
1025+
*/
1026+
public function updateMergeRequest(int $mergeRequestId, array $data): array
10091027
{
10101028
/** @var array $mrDetail */
10111029
$mrDetail = $this->apiPutJson(
10121030
"merge-request/{$mergeRequestId}",
1013-
[
1014-
'title' => $title,
1015-
'description' => $description,
1016-
],
1031+
$data,
10171032
);
10181033
return $mrDetail;
10191034
}
@@ -1942,10 +1957,10 @@ private function uploadFileToGcs(
19421957
$refreshCallableWrapper = new RefreshFileCredentialsWrapper($this, $prepareResult['id']);
19431958
$gcsUploader = new GCSUploader([
19441959
'credentials' => [
1945-
'access_token' => $prepareResult['gcsUploadParams']['access_token'],
1946-
'expires_in' => $prepareResult['gcsUploadParams']['expires_in'],
1947-
'token_type' => $prepareResult['gcsUploadParams']['token_type'],
1948-
],
1960+
'access_token' => $prepareResult['gcsUploadParams']['access_token'],
1961+
'expires_in' => $prepareResult['gcsUploadParams']['expires_in'],
1962+
'token_type' => $prepareResult['gcsUploadParams']['token_type'],
1963+
],
19491964
'projectId' => $prepareResult['gcsUploadParams']['projectId'],
19501965
], $refreshCallableWrapper);
19511966

0 commit comments

Comments
 (0)