Merge pull request #39 from keep-network/top-counter-continue

lukasz-zimnoch · web-flow · commit 55f9673ada06 · 2020-06-29T15:51:55.000+02:00
Continue when block number could not be parsed
diff --git a/pkg/chain/ethereum/blockcounter/blockcounter.go b/pkg/chain/ethereum/blockcounter/blockcounter.go
@@ -101,8 +101,8 @@ func (ebc *EthereumBlockCounter) receiveBlocks() {
 	for block := range ebc.subscriptionChannel {
 		topBlockNumber, err := strconv.ParseInt(block.Number, 0, 32)
 		if err != nil {
-			// FIXME Consider the right thing to do here.
 			logger.Errorf("error receiving a new block: [%v]", err)
+			continue
 		}
 
 		// receivedBlockHeight is the current blockchain height as just

Original file line number	Diff line number	Diff line change
`@@ -101,8 +101,8 @@ func (ebc *EthereumBlockCounter) receiveBlocks() {`
`101`	`101`	`for block := range ebc.subscriptionChannel {`
`102`	`102`	`topBlockNumber, err := strconv.ParseInt(block.Number, 0, 32)`
`103`	`103`	`if err != nil {`
`104`		`- // FIXME Consider the right thing to do here.`
`105`	`104`	`logger.Errorf("error receiving a new block: [%v]", err)`
	`105`	`+ continue`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`// receivedBlockHeight is the current blockchain height as just`