Commit 94d2520
committed
Check if chainId is not nil before constructing EIP155 signer
EIP155 signer does not perform chain ID validation and if chain ID is
nil, transaction is rejected by Ethereum client as not being EIP155
compliant. A simple chainId nil check was added in this commit. A
similar check is performed in the original go-ethereum code in
NewKeyedTransactorWithChainID function.1 parent 67241db commit 94d2520
2 files changed
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
64 | 67 | | |
65 | 68 | | |
66 | 69 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
67 | 70 | | |
68 | 71 | | |
69 | 72 | | |
| |||
0 commit comments