Merge pull request #74 from keep-network/rfc-18/move-gosec-to-client-yml

Cleanup of Go workflow

This PR introduces a couple of cleanup changes in Go workflow, as part
of work on RFC-18. Those changes are:
* Moving `scan` job from `gosec.yml` to `client.yml` (there is no need
to keep them in separate workflows)
* Adding `client-` prefix to `scan` and `build-and-test` jobs (to avoid
confusion in the future with other similar jobs that we may want to add
or remove from required list in branch protection settings)
* Removing test result puvblishing step (we've decided to resign from
using `EnricoMi/publish-unit-test-result-action` action, as it worked
in a confising way sometimes - was assigning the tests results to
incorrect workflows)
* Removing unnecessary comment

Author: nkuba

.github/workflows/client.yml

@@ -1,6 +1,5 @@
 name: Go
 
-#TODO: extend the conditions once workflow gets tested together with other workflows
 on:
   push:
     branches:
@@ -9,7 +8,7 @@ on:
   workflow_dispatch:
 
 jobs:
-  build-and-test:
+  client-build-and-test:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
@@ -25,20 +24,18 @@ jobs:
       - name: Build Go
         run: go build ./...
 
-      - name: Create test results directory
-        run: mkdir test-results
-
       - name: Install gotestsum
         run: go get gotest.tools/gotestsum
 
       - name: Run Go tests
-        run: gotestsum --junitfile test-results/unit-tests.xml
+        run: gotestsum
 
-      - name: Publish unit test results
-        uses: EnricoMi/publish-unit-test-result-action@v1
-        if: always()
+  client-scan:
+    runs-on: ubuntu-latest
+    env:
+      GO111MODULE: on
+    steps:
+      - uses: actions/checkout@v2
+      - uses: securego/gosec@master
         with:
-          github_token: ${{ secrets.GITHUB_TOKEN }}
-          files: ./test-results/unit-tests.xml
-          check_name: Go Test Results # name under which test results will be presented in GitHub (optional)
-          comment_on_pr: false # turns off commenting on Pull Requests
+          args: ./...