Skip to content
This repository was archived by the owner on May 22, 2023. It is now read-only.

Commit d210e1e

Browse files
authored
Merge pull request #943 from keep-network/use-fixed-sortition-pools-dependency
Using fixed version of sortition-pools package The keep-ecdsa contracts depend on some sortition-pools contracts which are no longer present in the latest npm packages (this is due to transision to v2). Until we stop supporting keep-ecdsa repo & contracts, we need to configure there the dependncy to the latest sortition-pools package which contains the required contracts. This is package @keep-network/sortition-pools@1.2.0-dev.1.
2 parents 516e37b + 76fb64d commit d210e1e

4 files changed

Lines changed: 22 additions & 17 deletions

File tree

.github/workflows/contracts.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,6 @@ jobs:
134134
135135
- name: Resolve latest contracts
136136
run: |
137-
npm update @keep-network/sortition-pools
138137
npm install --save-exact \
139138
@keep-network/keep-core@${{ steps.upstream-builds-query.outputs.keep-core-contracts-version }}
140139

.github/workflows/npm.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,7 @@ jobs:
3232
- name: Resolve latest contracts
3333
working-directory: ./solidity
3434
run: |
35-
npm update --save-exact \
36-
@keep-network/keep-core \
37-
@keep-network/sortition-pools
35+
npm update --save-exact @keep-network/keep-core
3836
3937
- name: Compile contracts
4038
run: npx truffle compile

solidity/package-lock.json

Lines changed: 20 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

solidity/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"homepage": "https://github.com/keep-network/keep-ecdsa",
3030
"dependencies": {
3131
"@keep-network/keep-core": ">1.8.0-dev <1.8.0-pre",
32-
"@keep-network/sortition-pools": ">1.2.0-dev <1.2.0-pre",
32+
"@keep-network/sortition-pools": "1.2.0-dev.1",
3333
"@openzeppelin/upgrades": "^2.7.2",
3434
"openzeppelin-solidity": "2.3.0"
3535
},

0 commit comments

Comments
 (0)