Skip to content

Commit 9b2fae7

Browse files
committed
fix: Remove Windows cross-compilation from Linux build
Wine is not available in the GitHub Actions Linux runner by default, causing the build to fail. Each platform will now only build its native packages: - Linux builds: .deb, .AppImage - Windows builds: .exe, .msi - macOS builds: .dmg, .zip
1 parent 743c2e5 commit 9b2fae7

1 file changed

Lines changed: 1 addition & 17 deletions

File tree

.github/workflows/build-electron.yml

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -82,14 +82,10 @@ jobs:
8282
path: checksum.txt
8383
if-no-files-found: error
8484

85-
- name: Linux - Build Electron App (All Platforms)
85+
- name: Linux - Build Electron App
8686
if: startsWith(matrix.os, 'ubuntu')
8787
run: |
88-
# Build for Linux
8988
yarn run release
90-
# Also build Windows packages from Linux (cross-platform)
91-
cd packages/keepkey-desktop
92-
yarn electron-builder --win --publish=never
9389
env:
9490
NODE_ENV: production
9591
GH_TOKEN: ${{ secrets.github_token }}
@@ -152,18 +148,6 @@ jobs:
152148
packages/keepkey-desktop/dist/*.AppImage.blockmap
153149
if-no-files-found: error
154150

155-
- name: Linux - Upload Windows packages (cross-platform build)
156-
if: startsWith(matrix.os, 'ubuntu')
157-
uses: actions/upload-artifact@v4
158-
with:
159-
name: windows-from-linux-${{ matrix.os }}
160-
path: |
161-
packages/keepkey-desktop/dist/*.exe
162-
packages/keepkey-desktop/dist/*.msi
163-
packages/keepkey-desktop/dist/*.exe.blockmap
164-
packages/keepkey-desktop/dist/*.msi.blockmap
165-
if-no-files-found: warn
166-
167151
- name: Mac - Upload .dmg
168152
if: startsWith(matrix.os, 'macos')
169153
uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)