Skip to content

Commit d489228

Browse files
committed
fix: Disable code signing for builds
- Set identity to null in electron-builder config - Remove all Apple signing environment variables from workflow - Set hardenedRuntime to false - Add CSC_IDENTITY_AUTO_DISCOVERY=false to prevent auto-signing - Remove notarization preparation step This ensures builds can complete without requiring signing certificates.
1 parent c707172 commit d489228

2 files changed

Lines changed: 3 additions & 20 deletions

File tree

.github/workflows/build-electron.yml

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -82,14 +82,6 @@ jobs:
8282
path: checksum.txt
8383
if-no-files-found: error
8484

85-
- name: Mac - Prepare For App Notarization
86-
if: startsWith(matrix.os, 'macos')
87-
run: |
88-
mkdir -p ~/private_keys/
89-
echo '${{ secrets.api_key }}' > ~/private_keys/AuthKey_${{ secrets.api_key_id }}.p8
90-
ls -al ~/private_keys # Debugging line to check the contents of the directory
91-
chmod -R 755 ~/private_keys # Ensure proper permissions
92-
9385
- name: Linux - Build Electron App (All Platforms)
9486
if: startsWith(matrix.os, 'ubuntu')
9587
run: |
@@ -100,9 +92,6 @@ jobs:
10092
yarn electron-builder --win --publish=never
10193
env:
10294
NODE_ENV: production
103-
APPLE_ID: ${{ secrets.apple_id }}
104-
APPLE_ID_PASSWORD: ${{ secrets.apple_id_password }}
105-
APPLE_TEAM_ID: ${{ secrets.apple_team_id }}
10695
GH_TOKEN: ${{ secrets.github_token }}
10796

10897
- name: Mac - Build Electron App
@@ -122,14 +111,7 @@ jobs:
122111
env:
123112
NODE_ENV: production
124113
GH_TOKEN: ${{ secrets.github_token }}
125-
CSC_LINK: ${{ secrets.mac_certs }}
126-
APPLE_API_KEY: ${{ secrets.apple_api_key }}
127-
APPLE_API_KEY_ID: ${{ secrets.apple_api_key_id }}
128-
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.apple_app_specific_password }}
129-
APPLE_ID: ${{ secrets.apple_id }}
130-
APPLE_ID_PASSWORD: ${{ secrets.apple_id_password }}
131-
APPLE_TEAM_ID: ${{ secrets.apple_team_id }}
132-
CSC_KEY_PASSWORD: ${{ secrets.mac_certs_password }}
114+
CSC_IDENTITY_AUTO_DISCOVERY: false
133115

134116
- name: Windows - Build Electron App
135117
if: startsWith(matrix.os, 'windows')

packages/keepkey-desktop/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,14 @@
4343
"asar": true,
4444
"extends": null,
4545
"mac": {
46-
"hardenedRuntime": true,
46+
"hardenedRuntime": false,
4747
"category": "public.app-category.finance",
4848
"icon": "icon.png",
4949
"entitlements": "entitlements.mac.plist",
5050
"entitlementsInherit": "entitlements.mac.plist",
5151
"mergeASARs": false,
5252
"notarize": false,
53+
"identity": null,
5354
"target": [
5455
{
5556
"target": "dmg",

0 commit comments

Comments
 (0)