Skip to content

Commit e440511

Browse files
committed
refactor: remove WebRTCRelayEnabled config, always register endpoint
The relay is lazy-started on first request so there's no cost to always registering the /display/webrtc endpoint. No need for a config toggle. Made-with: Cursor
1 parent fa3844f commit e440511

2 files changed

Lines changed: 10 additions & 18 deletions

File tree

server/cmd/api/main.go

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -141,21 +141,17 @@ func main() {
141141
// the VP8 video stream to external WebRTC clients via a single
142142
// WebSocket signaling endpoint. The Neko connection is lazy —
143143
// it only starts when the first client connects.
144-
if config.WebRTCRelayEnabled {
145-
relay, err := webrtcscreen.NewRelay(ctx, webrtcscreen.RelayConfig{
146-
NekoBaseURL: "http://127.0.0.1:8080",
147-
NekoUser: "admin",
148-
NekoPass: adminPassword,
149-
Logger: slogger,
150-
})
151-
if err != nil {
152-
slogger.Error("failed to create webrtc relay", "err", err)
153-
os.Exit(1)
154-
}
155-
156-
r.Get("/display/webrtc", relay.HandleWebSocket)
157-
slogger.Info("webrtc relay endpoint registered at /display/webrtc (lazy start)")
144+
relay, err := webrtcscreen.NewRelay(ctx, webrtcscreen.RelayConfig{
145+
NekoBaseURL: "http://127.0.0.1:8080",
146+
NekoUser: "admin",
147+
NekoPass: adminPassword,
148+
Logger: slogger,
149+
})
150+
if err != nil {
151+
slogger.Error("failed to create webrtc relay", "err", err)
152+
os.Exit(1)
158153
}
154+
r.Get("/display/webrtc", relay.HandleWebSocket)
159155

160156
srv := &http.Server{
161157
Addr: fmt.Sprintf(":%d", config.Port),

server/cmd/config/config.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,6 @@ type Config struct {
3131
// DevTools proxy address passed to ChromeDriver as goog:chromeOptions.debuggerAddress.
3232
// If empty, it is derived from DevToolsProxyPort as 127.0.0.1:<port>.
3333
DevToolsProxyAddr string `envconfig:"DEVTOOLS_PROXY_ADDR" default:""`
34-
35-
// WebRTC relay: connects to Neko internally and re-serves the video
36-
// stream to external WebRTC clients via /display/webrtc.
37-
WebRTCRelayEnabled bool `envconfig:"WEBRTC_RELAY_ENABLED" default:"true"`
3834
}
3935

4036
// Load loads configuration from environment variables

0 commit comments

Comments
 (0)