Fix failed CI

Author: tungleduyxyz

app/controllers/kaui/accounts_controller.rb

@@ -177,7 +177,7 @@ def new
     def edit; end
 
     def create
-      @account = Kaui::Account.new(params.require(:account).to_h.compact_blank)
+      @account = Kaui::Account.new(params.require(:account).permit!.to_h.compact_blank)
 
       @account.errors.add(:phone, :invalid_phone) if !@account.phone.nil? && !@account.check_account_details_phone?
 
@@ -202,7 +202,7 @@ def create
     end
 
     def update
-      @account = Kaui::Account.new(params.require(:account).to_h.compact_blank)
+      @account = Kaui::Account.new(params.require(:account).permit!.to_h.compact_blank)
       @account.account_id = params.require(:account_id)
 
       # Transform "1" into boolean
@@ -309,7 +309,7 @@ def validate_external_key
     end
 
     def link_to_parent
-      @account = Kaui::Account.new(params.require(:account).to_h.compact_blank)
+      @account = Kaui::Account.new(params.require(:account).permit!.to_h.compact_blank)
       @account.account_id = params.require(:account_id)
       @account.is_payment_delegated_to_parent = @account.is_payment_delegated_to_parent == '1'
 

app/controllers/kaui/admin_tenants_controller.rb

@@ -234,7 +234,7 @@ def create_simple_plan
       options = tenant_options_for_client
       fetch_state_for_new_catalog_screen(options)
 
-      simple_plan = params.require(:simple_plan).to_h.compact_blank
+      simple_plan = params.require(:simple_plan).permit!.to_h.compact_blank
       # Fix issue in Rails where first entry in the multi-select array is an empty string
       simple_plan['available_base_products']&.reject!(&:blank?)
 
@@ -298,7 +298,7 @@ def modify_overdue_config
       options[:api_key] = current_tenant.api_key
       options[:api_secret] = current_tenant.api_secret
 
-      view_form_model = params.require(:kill_bill_client_model_overdue).to_h.compact_blank
+      view_form_model = params.require(:kill_bill_client_model_overdue).permit!.to_h.compact_blank
       view_form_model['states'] = view_form_model['states'].values if view_form_model['states'].present?
 
       overdue = Kaui::Overdue.from_overdue_form_model(view_form_model)

app/controllers/kaui/charges_controller.rb

@@ -19,13 +19,16 @@ def new
     end
 
     def create
-      charge = Kaui::InvoiceItem.new(params.require(:invoice_item).to_h.compact_blank)
+      charge = Kaui::InvoiceItem.new(params.require(:invoice_item).permit!.to_h.compact_blank)
       charge.account_id ||= params.require(:account_id)
 
+      # Preserve the original invoice_id since the API may not return it
+      original_invoice_id = charge.invoice_id
+
       auto_commit = params[:auto_commit] == '1'
 
       charge = charge.create(auto_commit, current_user.kb_username, params[:reason], params[:comment], options_for_klient)
-      redirect_to kaui_engine.account_invoice_path(charge.account_id, charge.invoice_id), notice: 'Charge was successfully created'
+      redirect_to kaui_engine.account_invoice_path(charge.account_id, charge.invoice_id || original_invoice_id), notice: 'Charge was successfully created'
     end
   end
 end

app/controllers/kaui/credits_controller.rb

@@ -19,7 +19,7 @@ def new
     end
 
     def create
-      credit = Kaui::Credit.new(params[:credit].to_h.compact_blank)
+      credit = Kaui::Credit.new(params[:credit].permit!.to_h.compact_blank)
       credit.account_id ||= params.require(:account_id)
 
       # No need to show the newly created invoice for account level credits

app/controllers/kaui/payment_methods_controller.rb

@@ -12,7 +12,7 @@ def new
     end
 
     def create
-      @payment_method             = Kaui::PaymentMethod.new(params[:payment_method].to_h.compact_blank)
+      @payment_method             = Kaui::PaymentMethod.new(params[:payment_method].permit!.to_h.compact_blank)
       # Transform "1" into boolean
       @payment_method.is_default  = @payment_method.is_default == '1'
       # Sensible default

app/controllers/kaui/subscriptions_controller.rb

@@ -35,7 +35,7 @@ def edit
     def create
       plan_name = params.require(:plan_name)
       @base_product_name = params[:base_product_name]
-      @subscription = Kaui::Subscription.new(params.require(:subscription).to_h.compact_blank)
+      @subscription = Kaui::Subscription.new(params.require(:subscription).permit!.to_h.compact_blank)
 
       begin
         @bundle, plans_details = lookup_bundle_and_plan_details(@subscription, @base_product_name)

app/controllers/kaui/transactions_controller.rb

@@ -24,7 +24,7 @@ def new
     end
 
     def create
-      transaction = Kaui::Transaction.new(params[:transaction].to_h.compact_blank)
+      transaction = Kaui::Transaction.new(params[:transaction].permit!.to_h.compact_blank)
 
       plugin_properties = params[:plugin_properties].values.reject { |item| item['value'].blank? || item['key'].blank? } if params[:plugin_properties].present?
       if plugin_properties.present?
@@ -43,7 +43,7 @@ def create
     end
 
     def fix_transaction_state
-      transaction = Kaui::Transaction.new(params[:transaction].to_h.compact_blank)
+      transaction = Kaui::Transaction.new(params[:transaction].permit!.to_h.compact_blank)
       payment_id = transaction.payment_id
       transaction_id = transaction.transaction_id
       transaction_status = transaction.status

app/models/kaui/killbill_authenticatable.rb

@@ -2,8 +2,6 @@
 
 require 'killbill_client'
 
-# rubocop:disable Style/ClassAndModuleChildren, Style/OneClassPerFile
-
 # Hack for Zeitwerk - must define Kaui::KillbillAuthenticatable before Devise::Models::KillbillAuthenticatable
 module Kaui
   module KillbillAuthenticatable; end

app/models/kaui/killbill_registerable.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-# rubocop:disable Style/ClassAndModuleChildren, Style/OneClassPerFile
-
 # Hack for Zeitwerk - must define Kaui::KillbillRegisterable before Devise::Models::KillbillRegisterable
 module Kaui
   module KillbillRegisterable; end
@@ -14,4 +12,3 @@ module KillbillRegisterable
     end
   end
 end
-# rubocop:enable Style/ClassAndModuleChildren, Style/OneClassPerFile

test/functional/kaui/functional_test_helper_nosetup.rb

@@ -48,6 +48,8 @@ def login_as_admin
         get :new
         post :create, params: { user: { kb_username: USERNAME, password: PASSWORD } }
       end
+      # Clear Devise's "Signed in successfully." flash to avoid polluting subsequent assertions
+      flash.clear
     end
 
     def logout