Allow manual total when doing a refund with item adjustment

[travisirby]

For refunds of invoices that have line items with associated tax lines, when choosing to do item adjustments as part of the refund the total amount to refund is a read only field that is calculated by the items chosen to adjust.

This is problematic for the use-case where I want to refund the full invoice total, but I only want to adjust the non tax line items. This is because the tax line items will be automatically adjusted when their associated line items are adjusted. If the tax line items are selected for adjustment in the refund page the adjustment will be more than the total of the invoice creating a positive account balance. If I only select the non tax line items for adjustment the refund will not be for the total amount of the invoice.

I have confirmed that the behavior in kill bill using direct kill bill api call works as expected if I set the amount to refund to the total of the invoice and only include the non tax line items in the adjustments parameter. So this appears to be only a kaui limitation

[tungleduyxyz]

Hi @reshmabidikar , the recent update allows users to customize descriptions and amounts for items

[reshmabidikar]

The ticket indicates that the issue occurs when a user tries to refund a payment with invoice item adjustment:

In this case, the total amount field is read-only and is calculated based on the selected items. As per this ticket, the total amount should be editable. This is allowed via the API call:

curl -v \
    -X POST \
    -u admin:password \
    -H 'X-Killbill-ApiKey: aviate' \
    -H 'X-Killbill-ApiSecret: aviate' \
    -H 'Content-Type: application/json' \
    -H 'X-Killbill-CreatedBy: demo' \
    -d '{
          "amount": 8,
          "isAdjusted": true,
          "adjustments": [
            {
              "accountId": "c6f526dd-8b67-4fb2-bab4-aa7e7811d4e0",
              "invoiceItemId": "df305b24-090a-4f45-a44e-333d58c6d9a4",
              "description": "recurring refund",
              "amount": 5,
              "currency": "GBP"
            },
            {
              "accountId": "c6f526dd-8b67-4fb2-bab4-aa7e7811d4e0",
              "invoiceItemId": "e2dcdb16-9372-419a-860f-fa6fcb1a5dd9",
              "description": "tax refund",
              "amount": 1,
              "currency": "GBP"
            }
          ]
        }' \
    'http://127.0.0.1:8080/1.0/kb/invoicePayments/3d95e8f6-6a7a-4281-bdb5-676312fcbf5c/refunds'

[reshmabidikar]

Tested with Kaui 4.0.13-f2f4285 and the issue is now addressed, I'm able to edit the total amount:

Closing this ticket