fix ansible lint errors

Author: reshmabidikar

ansible/diagnostic.yml

@@ -18,4 +18,4 @@
         killbill_account: "{{ killbill_account | default('') }}"
         bundles_dir: "{{ kb_plugins_dir }}"
         log_dir: "{{ catalina_base }}/logs"
-      tags: diagnostics
+      tags: diagnostics

ansible/roles/common/tasks/main.yml

@@ -3,4 +3,4 @@
   set_fact: ansible_ruby_interpreter="{{ kpm_path }}/lib/ruby/bin/ruby"
   tags: common
   # noqa: var-naming[no-role-prefix]
-  # Required for ansible-lint: variable must stay named 'ansible_ruby_interpreter' for Ansible to pick it up
+  # Required for ansible-lint: variable must stay named 'ansible_ruby_interpreter' for Ansible to pick it up

ansible/roles/kaui/tasks/main.yml

@@ -21,7 +21,7 @@
     owner: "{{ tomcat_owner }}"
     group: "{{ tomcat_group }}"
     # If the file already exist, don't clobber it
-    force: no
+    force: false
   tags: kpm-install
 
 # Generate Kaui-specific Tomcat configuration files based on environment variables
@@ -34,7 +34,7 @@
     owner: "{{ tomcat_owner }}"
     group: "{{ tomcat_group }}"
     # If the files already exist, don't clobber them
-    force: no
+    force: false
   with_items:
     - src: kaui/conf
       name: setenv2.sh
@@ -68,7 +68,7 @@
     path: "{{ kaui_install_dir }}"
     owner: "{{ tomcat_owner }}"
     group: "{{ tomcat_group }}"
-    recurse: yes
+    recurse: true
   tags: kpm-install
 
 - name: Create ROOT directory to unarchive the WAR
@@ -108,7 +108,7 @@
   ansible.builtin.file:
     path: "{{ catalina_base }}/{{ kaui_webapps }}/ROOT"
     state: directory
-    recurse: yes
+    recurse: true
     owner: "{{ tomcat_owner }}"
     group: "{{ tomcat_group }}"
     mode: u=rwX,g=rX,o=rX

ansible/roles/killbill/tasks/main.yml

@@ -22,7 +22,7 @@
     owner: "{{ tomcat_owner }}"
     group: "{{ tomcat_group }}"
     # If the files already exist, don't clobber them
-    force: no
+    force: false
   with_items:
     - name: killbill.properties
   tags: kpm-install
@@ -36,7 +36,7 @@
     owner: "{{ tomcat_owner }}"
     group: "{{ tomcat_group }}"
     # If the file already exist, don't clobber it
-    force: no
+    force: false
   tags: kpm-install
 
 # Generate Kill Bill-specific Tomcat configuration files based on environment variables
@@ -49,7 +49,7 @@
     owner: "{{ tomcat_owner }}"
     group: "{{ tomcat_group }}"
     # If the files already exist, don't clobber them
-    force: no
+    force: false
   with_items:
     - src: killbill/conf
       name: setenv2.sh
@@ -83,7 +83,7 @@
     path: "{{ kb_install_dir }}"
     owner: "{{ tomcat_owner }}"
     group: "{{ tomcat_group }}"
-    recurse: yes
+    recurse: true
   tags: kpm-install
 
 - name: Create ROOT directory to unarchive the WAR
@@ -123,7 +123,7 @@
   ansible.builtin.file:
     path: "{{ catalina_base }}/{{ kb_webapps }}/ROOT"
     state: directory
-    recurse: yes
+    recurse: true
     owner: "{{ tomcat_owner }}"
     group: "{{ tomcat_group }}"
     mode: u=rwX,g=rX,o=rX

ansible/roles/kpm/tasks/main.yml

@@ -10,7 +10,7 @@
 - name: Download kpm release metadata
   ansible.builtin.uri:
     url: "{{ nexus_url }}/{{ nexus_repository }}/org/kill-bill/billing/installer/kpm/maven-metadata.xml"
-    return_content: yes
+    return_content: true
   register: kpm_metadata
   when: kpm_version is undefined
   tags: kpm
@@ -54,7 +54,7 @@
   become: true
   ansible.builtin.unarchive:
     src: "{{ kpm_install_dir }}/kpm-{{ kpm_version }}-noarch.tar.gz"
-    remote_src: True
+    remote_src: true
     dest: "{{ kpm_install_dir }}"
     owner: "{{ kpm_owner }}"
     group: "{{ kpm_group }}"
@@ -85,7 +85,7 @@
   become: true
   ansible.builtin.unarchive:
     src: "{{ kpm_install_dir }}/kpm-{{ kpm_version }}-linux-{{ ansible_architecture }}.tar.gz"
-    remote_src: True
+    remote_src: true
     dest: "{{ kpm_install_dir }}"
     owner: "{{ kpm_owner }}"
     group: "{{ kpm_group }}"
@@ -116,5 +116,5 @@
     path: "{{ kpm_install_dir }}/kpm-{{ kpm_version }}-linux-{{ ansible_architecture }}"
     owner: "{{ kpm_owner }}"
     group: "{{ kpm_group }}"
-    recurse: yes
+    recurse: true
   tags: kpm

ansible/roles/migrations/tasks/flyway.yml

@@ -21,7 +21,7 @@
     - name: Download killbill-flyway release metadata
       ansible.builtin.uri:
         url: "{{ nexus_url }}/{{ nexus_repository }}/org/kill-bill/billing/killbill-util/maven-metadata.xml"
-        return_content: yes
+        return_content: true
       register: migrations_flyway_metadata
       when: migrations_flyway_version is undefined
       tags: migrations

ansible/roles/migrations/tasks/main.yml

@@ -33,7 +33,7 @@
     - "{{ migrations_result['migrations']['killbill'] }}"
     - "{{ migrations_result['migrations']['plugins']['java'] }}"
   when: item['dir'] is defined
-  changed_when: False
+  changed_when: false
   register: migrations_java_dry_run_migrations
   tags: migrations
 
@@ -53,4 +53,3 @@
   loop_control:
     loop_var: migration
   when: migration['dir'] is defined
-

ansible/roles/migrations/tasks/migrate.yml

@@ -32,7 +32,7 @@
         - name: Run SQL migration
           ansible.builtin.command: "{{ flyway }} -locations=filesystem:{{ migration['dir'] }} -table={{ migration['table'] }} -validateOnMigrate=false migrate"
           register: migrations_flyway_result
-          ignore_errors: True
+          ignore_errors: true
           changed_when: false
           tags: migrations
 

ansible/roles/plugins/tasks/main.yml

@@ -17,5 +17,3 @@
     plugin_key: "{{ plugin_key }}"
     local_node_only: "{{ local_node_only | default(false) }}"
   tags: plugin-restart
-
-

ansible/roles/tomcat/tasks/install.yml

@@ -21,7 +21,7 @@
     name: "{{ tomcat_owner }}"
     comment: Kill Bill Tomcat owner
     group: "{{ tomcat_group }}"
-    create_home: yes
+    create_home: true
     home: "{{ tomcat_home }}"
     shell: /bin/bash
     state: present
@@ -30,7 +30,7 @@
 - name: Download Tomcat release metadata
   ansible.builtin.uri:
     url: "{{ nexus_url }}/{{ nexus_repository }}/org/apache/tomcat/tomcat/maven-metadata.xml"
-    return_content: yes
+    return_content: true
   register: tomcat_metadata
   when: tomcat_version is undefined
   tags: install
@@ -46,7 +46,7 @@
   become: true
   ansible.builtin.unarchive:
     src: "http://archive.apache.org/dist/tomcat/tomcat-9/v{{ tomcat_version }}/bin/apache-tomcat-{{ tomcat_version }}.tar.gz"
-    remote_src: True
+    remote_src: true
     dest: "{{ tomcat_install_dir }}"
     owner: "{{ tomcat_owner }}"
     group: "{{ tomcat_group }}"