add —no-verify and screenshot instructions

Author: robertherber

general/skills/ralph/SKILL.md

@@ -1,7 +1,7 @@
 ---
 name: ralph
 description: "Convert PRDs to prd.json format for the Ralph autonomous agent system. Use when you have an existing PRD and need to convert it to Ralph's JSON format. Triggers on: convert this prd, turn this into ralph format, create prd.json from this, ralph json."
-user-invokable: true
+user-invocable: true
 ---
 
 # Ralph PRD Converter

planning/.claude-plugin/plugin.json

@@ -13,7 +13,7 @@ You are an autonomous coding agent working on a software project.
 7. Update CLAUDE.md files if you discover reusable patterns (see below)
 8. If checks pass, commit ALL changes with message: `feat: [Story ID] - [Story Title]`
 9. Update the PRD to set `passes: true` for the completed story
-10. Append your progress to `progress.txt`
+10. Append your progress to `progress.txt`. When doing UI-related things and testing in browser or simulator tasks take screenshots of the results (one or max two per modified screen) and reference them in progress.txt
 
 ## Progress Report Format
 
@@ -22,6 +22,7 @@ APPEND to progress.txt (never replace, always append):
 ## [Date/Time] - [Story ID]
 - What was implemented
 - Files changed
+- References to screenshots taken (e.g. "See screenshot: progress-screenshots/story-id.png") with a brief description of what the screenshot shows
 - **Learnings for future iterations:**
   - Patterns discovered (e.g., "this codebase uses X for Y")
   - Gotchas encountered (e.g., "don't forget to update Z when changing W")

planning/skills/plan/SKILL.md

@@ -42,7 +42,7 @@ export async function checkoutBranch(workDir: string, branch: string): Promise<v
 
 export async function pushBranch(workDir: string, branch?: string): Promise<void> {
   const branchName = branch ?? await getCurrentBranch(workDir);
-  await $`git -C ${workDir} push -u origin ${branchName}`;
+  await $`git -C ${workDir} push -u origin ${branchName} --no-verify`;
 }
 
 export async function getCurrentBranch(workDir: string): Promise<string> {

scripts/eternity-loop/eternity-loop-prompts/ralph-claude-md.md

@@ -1,5 +1,6 @@
 import type { Octokit } from "@octokit/rest";
 import { graphql } from "@octokit/graphql";
+import { join, basename } from "node:path";
 
 export async function findPrByBranch(
   octokit: Octokit,
@@ -287,3 +288,101 @@ export async function countWorkflowRunsSinceLastHumanInteraction(
     new Date(c.createdAt) > cutoff
   ).length;
 }
+
+/**
+ * Extract screenshot file paths referenced in progress.txt content.
+ * Looks for image file paths (relative or absolute) in the text.
+ */
+export function extractScreenshotPaths(progressContent: string, workDir: string): string[] {
+  const paths: string[] = [];
+
+  // Match file paths ending in image extensions
+  // Handles: ./path/to/file.png, path/to/file.png, /absolute/path/file.png
+  // Also handles paths in markdown image syntax: ![alt](path.png)
+  const pathPattern = /(?:!\[[^\]]*\]\()?([^\s\n\r"'()]+\.(?:png|jpg|jpeg|gif|webp|svg))(?:\))?/gi;
+
+  for (const match of progressContent.matchAll(pathPattern)) {
+    const filePath = match[1];
+    if (!filePath) continue;
+
+    // Resolve relative paths against workDir
+    const resolved = filePath.startsWith("/") ? filePath : join(workDir, filePath);
+    if (!paths.includes(resolved)) {
+      paths.push(resolved);
+    }
+  }
+
+  return paths;
+}
+
+/**
+ * Get the relative path of a file within a git repo.
+ */
+async function getRelativePath(workDir: string, absolutePath: string): Promise<string> {
+  // If path is already relative (starts within workDir), extract relative portion
+  if (absolutePath.startsWith(workDir)) {
+    return absolutePath.slice(workDir.length).replace(/^\//, "");
+  }
+  // Otherwise try git to resolve
+  try {
+    const result = await Bun.$`git -C ${workDir} ls-files --full-name ${absolutePath}`.text();
+    return result.trim();
+  } catch {
+    return basename(absolutePath);
+  }
+}
+
+/**
+ * Upload screenshots referenced in progress.txt to the PR as a comment.
+ * Screenshots that are committed to the branch are referenced via raw GitHub URLs.
+ * Screenshots not yet tracked are committed first, then referenced.
+ */
+export async function uploadProgressScreenshots(
+  octokit: Octokit,
+  owner: string,
+  repo: string,
+  prNumber: number,
+  progressContent: string,
+  workDir: string,
+  branch: string,
+): Promise<void> {
+  const screenshotPaths = extractScreenshotPaths(progressContent, workDir);
+  if (screenshotPaths.length === 0) return;
+
+  const imageEntries: Array<{ name: string; url: string }> = [];
+
+  for (const filePath of screenshotPaths) {
+    const file = Bun.file(filePath);
+    if (!(await file.exists())) continue;
+
+    const relativePath = await getRelativePath(workDir, filePath);
+    const name = basename(filePath);
+
+    // Check if file is tracked in git
+    try {
+      await Bun.$`git -C ${workDir} ls-files --error-unmatch ${filePath}`.quiet();
+    } catch {
+      // File not tracked - add and commit it
+      try {
+        await Bun.$`git -C ${workDir} add ${filePath}`.quiet();
+        await Bun.$`git -C ${workDir} commit -m ${"chore: add screenshot " + name}`.quiet();
+      } catch {
+        continue; // Skip if we can't commit
+      }
+    }
+
+    const rawUrl = `https://raw.githubusercontent.com/${owner}/${repo}/${branch}/${relativePath}`;
+    imageEntries.push({ name, url: rawUrl });
+  }
+
+  if (imageEntries.length === 0) return;
+
+  const body = [
+    `🤖 **eternity-loop bot:** Screenshots from this run:\n`,
+    ...imageEntries.map((entry, i) =>
+      `### Screenshot ${i + 1}\n![${entry.name}](${entry.url})\n`
+    ),
+  ].join("\n");
+
+  await postPrComment(octokit, owner, repo, prNumber, body);
+}

scripts/eternity-loop/git.ts

@@ -4,7 +4,7 @@ import type { Issue, WorkflowContext } from "../types";
 import { logDebug, logWorkflow, logPrdEntryCount } from "../logger";
 import { checkoutBranch, pushBranch, getHeadSha } from "../git";
 import { createGitHubClient, getRepoInfo } from "../github/client";
-import { findPrByBranch, postPrComment } from "../github/pr";
+import { findPrByBranch, postPrComment, uploadProgressScreenshots } from "../github/pr";
 import { checkPrHasCiFailures, getCiFailureDetails, recordFixedSha } from "../github/ci";
 import { readPrompt } from "../prompts";
 import { ClaudeCliRunner } from "../ai-runner";
@@ -127,6 +127,9 @@ export class CiFixWorkflow implements Workflow {
       `🤖 **eternity-loop bot:** CI fix applied.\n\n<details><summary>Progress log</summary>\n\n${progress}\n\n</details>`,
     );
 
+    // Upload screenshots referenced in progress.txt
+    await uploadProgressScreenshots(octokit, owner, repo, issue.prNumber!, progress, ctx.workDir, issue.branchName);
+
     logWorkflow("ci-fix", `[ci-fix] Finalized CI fix for ${issue.identifier} — https://github.com/${owner}/${repo}/pull/${issue.prNumber}`);
   }
 }

scripts/eternity-loop/github/pr.ts

@@ -4,7 +4,7 @@ import type { Issue, WorkflowContext } from "../types";
 import { logDebug, logWorkflow, logPrdEntryCount } from "../logger";
 import { ensureMainBranch, checkoutBranch, pushBranch } from "../git";
 import { createGitHubClient, getRepoInfo } from "../github/client";
-import { createPr, postPrComment, findPrByBranch } from "../github/pr";
+import { createPr, postPrComment, findPrByBranch, uploadProgressScreenshots } from "../github/pr";
 import { readPrompt } from "../prompts";
 import { ClaudeCliRunner } from "../ai-runner";
 import { join } from "node:path";
@@ -95,6 +95,9 @@ export class NewFeatureWorkflow implements Workflow {
         `🤖 **eternity-loop bot:** Feature implementation complete.\n\n<details><summary>Progress log</summary>\n\n${progress}\n\n</details>`,
       );
 
+      // Upload screenshots referenced in progress.txt
+      await uploadProgressScreenshots(octokit, owner, repo, pr.number, progress, ctx.workDir, issue.branchName);
+
       logWorkflow("new-feature", `[new-feature] Created PR ${pr.url}`);
     } else {
       // Create draft PR via AI runner
@@ -109,6 +112,10 @@ export class NewFeatureWorkflow implements Workflow {
       await runner.run(fullPrompt, ctx.workDir);
 
       const draftPr = await findPrByBranch(octokit, owner, repo, issue.branchName);
+      if (draftPr) {
+        const draftProgress = await Bun.file(join(ctx.ralphDir, "progress.txt")).text();
+        await uploadProgressScreenshots(octokit, owner, repo, draftPr.number, draftProgress, ctx.workDir, issue.branchName);
+      }
       const draftUrl = draftPr ? draftPr.url : `https://github.com/${owner}/${repo}`;
       logWorkflow("new-feature", `[new-feature] Created draft PR for ${issue.identifier} — ${draftUrl}`);
     }

scripts/eternity-loop/workflows/ci-fix.ts

@@ -4,7 +4,7 @@ import type { Issue, WorkflowContext } from "../types";
 import { logDebug, logWorkflow, logPrdEntryCount } from "../logger";
 import { checkoutBranch, pushBranch, getLatestCommitDate } from "../git";
 import { createGitHubClient, getRepoInfo } from "../github/client";
-import { findPrByBranch, getPrComments, postPrComment, checkForNewHumanComments, countWorkflowRunsSinceLastHumanInteraction } from "../github/pr";
+import { findPrByBranch, getPrComments, postPrComment, checkForNewHumanComments, countWorkflowRunsSinceLastHumanInteraction, uploadProgressScreenshots } from "../github/pr";
 import { readPrompt } from "../prompts";
 import { ClaudeCliRunner } from "../ai-runner";
 import { join } from "node:path";
@@ -143,6 +143,9 @@ export class ReviewWorkflow implements Workflow {
       `🤖 **eternity-loop bot:** Review changes applied.\n\n<details><summary>Progress log</summary>\n\n${progress}\n\n</details>`,
     );
 
+    // Upload screenshots referenced in progress.txt
+    await uploadProgressScreenshots(octokit, owner, repo, issue.prNumber!, progress, ctx.workDir, issue.branchName);
+
     logWorkflow("review", `[review] Finalized review for ${issue.identifier} — https://github.com/${owner}/${repo}/pull/${issue.prNumber}`);
   }
 }