Skip to content

Commit 0fe65e1

Browse files
committed
chore: untrack generated example targets and align swiftlint paths
- ignore apps/example/targets as generated prebuild output to reduce churn - remove tracked example target artifacts from version control - point VS Code and pre-push lint command to TestHarness SwiftLint binary - document one-time pod install setup in CONTRIBUTING
1 parent a5761dc commit 0fe65e1

14 files changed

Lines changed: 24 additions & 147 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ android.iml
3939
# Example native output (CNG)
4040
apps/example/ios/
4141
apps/example/android/
42+
apps/example/targets/
4243

4344
# Cocoapods
4445
#

.vscode/settings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"cSpell.words": ["Triggerable"],
3-
"swiftlint.path": "apps/example/ios/Pods/SwiftLint/swiftlint",
3+
"swiftlint.path": "packages/react-native-device-activity/ios/TestHarness/Pods/SwiftLint/swiftlint",
44
"swift.SDK": "/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS18.2.sdk"
55
}

CONTRIBUTING.md

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ If these variables are missing, `app.config.ts` falls back to stable defaults fo
2222
## Example app follows CNG
2323

2424
The example app no longer tracks `apps/example/ios` and `apps/example/android`.
25+
The example target folder `apps/example/targets` is also generated during prebuild and should not be committed.
2526

2627
Regenerate native folders when needed:
2728

@@ -43,6 +44,25 @@ The iOS test runner lives in:
4344

4445
- `packages/react-native-device-activity/ios/TestHarness`
4546

47+
## SwiftLint setup
48+
49+
The repository runs SwiftLint from the iOS test harness CocoaPods installation:
50+
51+
- `packages/react-native-device-activity/ios/TestHarness/Pods/SwiftLint/swiftlint`
52+
53+
Run this once after cloning (and again if Pod dependencies are cleaned):
54+
55+
```bash
56+
cd packages/react-native-device-activity/ios/TestHarness
57+
pod install
58+
```
59+
60+
Then run repository checks from the root:
61+
62+
```bash
63+
bun run pre-push
64+
```
65+
4666
## Plugin testing
4767

4868
In addition to app/prebuild validation, config plugin regression tests are defined under:

apps/example/targets/ActivityMonitorExtension/Info.plist

Lines changed: 0 additions & 16 deletions
This file was deleted.

apps/example/targets/ActivityMonitorExtension/expo-target.config.js

Lines changed: 0 additions & 5 deletions
This file was deleted.

apps/example/targets/ActivityMonitorExtension/generated.entitlements

Lines changed: 0 additions & 12 deletions
This file was deleted.

apps/example/targets/ShieldAction/Info.plist

Lines changed: 0 additions & 15 deletions
This file was deleted.

apps/example/targets/ShieldAction/expo-target.config.js

Lines changed: 0 additions & 5 deletions
This file was deleted.

apps/example/targets/ShieldAction/generated.entitlements

Lines changed: 0 additions & 12 deletions
This file was deleted.

apps/example/targets/ShieldConfiguration/Info.plist

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)