Skip to content

Commit 4b2e742

Browse files
committed
add privacy: public to all logs
1 parent 6e39f6c commit 4b2e742

2 files changed

Lines changed: 19 additions & 14 deletions

File tree

packages/react-native-device-activity/ios/ReactNativeDeviceActivityModule.swift

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,8 @@ public class ReactNativeDeviceActivityModule: Module {
500500
during: schedule,
501501
events: dictionary
502502
)
503-
logger.log("✅ Succeeded with Starting Monitor Activity: \(activityName.rawValue)")
503+
logger.log(
504+
"✅ Succeeded with Starting Monitor Activity: \(activityName.rawValue, privacy: .public)")
504505

505506
}
506507

@@ -779,7 +780,8 @@ public class ReactNativeDeviceActivityModule: Module {
779780
case .success:
780781
continuation.resume()
781782
case .failure(let error):
782-
logger.log("❌ Failed to revoke authorization: \(error.localizedDescription)")
783+
logger.log(
784+
"❌ Failed to revoke authorization: \(error.localizedDescription, privacy: .public)")
783785
continuation.resume(throwing: error)
784786
}
785787
}

packages/react-native-device-activity/ios/Shared.swift

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,9 @@ func executeGenericAction(
146146
triggeredBy: triggeredBy
147147
)
148148
} else {
149-
logger.log("No familyActivitySelection found with ID: \(familyActivitySelectionId)")
149+
logger.log(
150+
"No familyActivitySelection found with ID: \(familyActivitySelectionId, privacy: .public)"
151+
)
150152
}
151153
}
152154
} else if type == "unblockSelection" {
@@ -735,7 +737,7 @@ func deserializeFamilyActivitySelection(familyActivitySelectionStr: String)
735737
do {
736738
activitySelection = try decoder.decode(FamilyActivitySelection.self, from: data!)
737739
} catch {
738-
logger.log("decode error \(error.localizedDescription)")
740+
logger.log("decode error \(error.localizedDescription, privacy: .public)")
739741
}
740742

741743
return activitySelection
@@ -1303,7 +1305,7 @@ func shouldExecuteAction(
13031305
) {
13041306
if lastTriggeredAt > skipIfAlreadyTriggeredAfter {
13051307
logger.log(
1306-
"skipping executing actions for \(callbackName)\(eventName ?? "") because the last triggered time is after \(skipIfAlreadyTriggeredAfter)"
1308+
"skipping executing actions for \(callbackName, privacy: .public)\(eventName ?? "", privacy: .public) because the last triggered time is after \(skipIfAlreadyTriggeredAfter, privacy: .public)"
13071309
)
13081310
return false
13091311
}
@@ -1324,7 +1326,7 @@ func shouldExecuteAction(
13241326
if lastTriggeredAt >= skipIfAlreadyTriggeredBetweenFromDate
13251327
&& lastTriggeredAt <= skipIfAlreadyTriggeredBetweenToDate {
13261328
logger.log(
1327-
"skipping executing actions for \(callbackName)\(eventName ?? "") because the last triggered time is between \(skipIfAlreadyTriggeredBetweenFromDate) and \(skipIfAlreadyTriggeredBetweenToDate)"
1329+
"skipping executing actions for \(callbackName, privacy: .public)\(eventName ?? "", privacy: .public) because the last triggered time is between \(skipIfAlreadyTriggeredBetweenFromDate, privacy: .public) and \(skipIfAlreadyTriggeredBetweenToDate, privacy: .public)"
13281330
)
13291331
return false
13301332
}
@@ -1339,7 +1341,7 @@ func shouldExecuteAction(
13391341
) {
13401342
if lastTriggeredAt < skipIfAlreadyTriggeredBefore {
13411343
logger.log(
1342-
"skipping executing actions for \(callbackName)\(eventName ?? "") because the last triggered time is after \(skipIfAlreadyTriggeredBefore)"
1344+
"skipping executing actions for \(callbackName, privacy: .public)\(eventName ?? "", privacy: .public) because the last triggered time is after \(skipIfAlreadyTriggeredBefore, privacy: .public)"
13431345
)
13441346
return false
13451347
}
@@ -1354,7 +1356,7 @@ func shouldExecuteAction(
13541356
afterDate: skipIfLargerEventRecordedAfter
13551357
) {
13561358
logger.log(
1357-
"skipping executing actions for \(eventName) because a larger event triggered after \(skipIfLargerEventRecordedAfter)"
1359+
"skipping executing actions for \(eventName, privacy: .public) because a larger event triggered after \(skipIfLargerEventRecordedAfter, privacy: .public)"
13581360
)
13591361
return false
13601362
}
@@ -1370,7 +1372,7 @@ func shouldExecuteAction(
13701372
Date().timeIntervalSince1970 * 1000 - skipIfAlreadyTriggeredWithinMS
13711373
if lastTriggeredAt > skipIfAlreadyTriggeredAfter {
13721374
logger.log(
1373-
"skipping executing actions for \(callbackName)\(eventName ?? "") because the last triggered time is after \(skipIfAlreadyTriggeredAfter)"
1375+
"skipping executing actions for \(callbackName, privacy: .public)\(eventName ?? "", privacy: .public) because the last triggered time is after \(skipIfAlreadyTriggeredAfter, privacy: .public)"
13741376
)
13751377
return false
13761378
}
@@ -1388,7 +1390,7 @@ func shouldExecuteAction(
13881390
afterDate: skipIfLargerEventRecordedAfter
13891391
) {
13901392
logger.log(
1391-
"skipping executing actions for \(eventName) because a larger event triggered after \(skipIfLargerEventRecordedAfter)"
1393+
"skipping executing actions for \(eventName, privacy: .public) because a larger event triggered after \(skipIfLargerEventRecordedAfter, privacy: .public)"
13921394
)
13931395
return false
13941396
}
@@ -1408,7 +1410,7 @@ func shouldExecuteAction(
14081410
afterDate: skipIfLargerEventRecordedAfter
14091411
) {
14101412
logger.log(
1411-
"skipping executing actions for \(eventName) because a larger event triggered after \(skipIfLargerEventRecordedAfter)"
1413+
"skipping executing actions for \(eventName, privacy: .public) because a larger event triggered after \(skipIfLargerEventRecordedAfter, privacy: .public)"
14121414
)
14131415
return false
14141416
}
@@ -1527,7 +1529,8 @@ func startMonitoringAction(
15271529
do {
15281530
try center.startMonitoring(activityName, during: schedule, events: eventDict)
15291531
logger.log(
1530-
"✅ Successfully started monitoring activity: \(activityName.rawValue) from \(triggeredBy)")
1532+
"✅ Successfully started monitoring activity: \(activityName.rawValue, privacy: .public) from \(triggeredBy, privacy: .public)"
1533+
)
15311534
} catch {
15321535
logger.log(
15331536
"❌ Failed to start monitoring activity: \(activityName.rawValue, privacy: .public) - \(error.localizedDescription, privacy: .public)"
@@ -1545,11 +1548,11 @@ func stopMonitoringAction(
15451548
let deviceActivityNames = activityNames.map { DeviceActivityName($0) }
15461549
center.stopMonitoring(deviceActivityNames)
15471550
logger.log(
1548-
"✅ Successfully stopped monitoring activities: \(activityNames.joined(separator: ", ")) from \(triggeredBy)"
1551+
"✅ Successfully stopped monitoring activities: \(activityNames.joined(separator: ", "), privacy: .public) from \(triggeredBy, privacy: .public)"
15491552
)
15501553
} else {
15511554
// Stop all monitoring
15521555
center.stopMonitoring()
1553-
logger.log("✅ Successfully stopped all monitoring from \(triggeredBy)")
1556+
logger.log("✅ Successfully stopped all monitoring from \(triggeredBy, privacy: .public)")
15541557
}
15551558
}

0 commit comments

Comments
 (0)