chore: migrate dev setup to env-driven CNG and package-owned iOS tests

Author: thisislvca

.github/workflows/test.yml

@@ -102,7 +102,7 @@ jobs:
         working-directory: apps/example
 
   swift-lint:
-    name: SwiftLint (example project)
+    name: SwiftLint (iOS harness)
     runs-on: macos-latest
     timeout-minutes: 10
     steps:
@@ -114,20 +114,20 @@ jobs:
 
       - uses: actions/cache@v4
         with:
-          path: apps/example/ios/Pods
-          key: ${{ runner.os }}-pods-${{ hashFiles('apps/example/ios/Podfile.lock') }}
+          path: packages/react-native-device-activity/ios/TestHarness/Pods
+          key: ${{ runner.os }}-pods-${{ hashFiles('packages/react-native-device-activity/ios/TestHarness/Podfile.lock') }}
           restore-keys: |
             ${{ runner.os }}-pods-
 
       - run: bun install
 
       - run: pod install
-        working-directory: apps/example/ios
+        working-directory: packages/react-native-device-activity/ios/TestHarness
 
-      - run: apps/example/ios/Pods/SwiftLint/swiftlint lint
+      - run: packages/react-native-device-activity/ios/TestHarness/Pods/SwiftLint/swiftlint lint --config .swiftlint.yml
 
   swift-test:
-    name: Swift Test (example project)
+    name: Swift Test (iOS harness)
     runs-on: macos-latest
     timeout-minutes: 25
     steps:
@@ -149,8 +149,8 @@ jobs:
 
       - uses: actions/cache@v4
         with:
-          path: apps/example/ios/Pods
-          key: ${{ runner.os }}-pods-${{ hashFiles('apps/example/ios/Podfile.lock') }}
+          path: packages/react-native-device-activity/ios/TestHarness/Pods
+          key: ${{ runner.os }}-pods-${{ hashFiles('packages/react-native-device-activity/ios/TestHarness/Podfile.lock') }}
           restore-keys: |
             ${{ runner.os }}-pods-
 
@@ -172,9 +172,7 @@ jobs:
         run: swift --version
 
       - run: pod install
-        working-directory: apps/example/ios
+        working-directory: packages/react-native-device-activity/ios/TestHarness
 
-      - run: cp .swiftlint.yml apps/example/ios
-
-      - run: xcodebuild test -workspace reactnativedeviceactivityexample.xcworkspace -scheme Tests -allowProvisioningUpdates -destination "platform=iOS Simulator,OS=latest,name=iPhone 17"
-        working-directory: apps/example/ios
+      - run: xcodebuild test -workspace reactnativedeviceactivityexample.xcworkspace -scheme Tests -destination "platform=iOS Simulator,OS=latest,name=iPhone 17" CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO
+        working-directory: packages/react-native-device-activity/ios/TestHarness

.gitignore

@@ -36,6 +36,10 @@ project.xcworkspace
 local.properties
 android.iml
 
+# Example native output (CNG)
+apps/example/ios/
+apps/example/android/
+
 # Cocoapods
 #
 apps/example/ios/Pods

.husky/pre-commit

@@ -1,2 +1,3 @@
-swift format -i -p -r ./packages/react-native-device-activity/ios ./packages/react-native-device-activity/targets ./apps/example/ios
-apps/example/ios/Pods/SwiftLint/swiftlint lint --fix
+swift format -i -p -r ./packages/react-native-device-activity/ios/Tests ./packages/react-native-device-activity/targets ./packages/react-native-device-activity/ios/TestHarness/reactnativedeviceactivityexample
+swift format -i -p ./packages/react-native-device-activity/ios/Shared.swift
+packages/react-native-device-activity/ios/TestHarness/Pods/SwiftLint/swiftlint lint --fix --config .swiftlint.yml

.swiftlint.yml

@@ -12,6 +12,11 @@ disabled_rules:
   - inclusive_language
 
 included:
-  - packages/react-native-device-activity/ios
-  - apps/example/ios
+  - packages/react-native-device-activity/ios/Tests
+  - packages/react-native-device-activity/ios/Shared.swift
+  - packages/react-native-device-activity/ios/TestHarness/reactnativedeviceactivityexample
   - packages/react-native-device-activity/targets
+
+excluded:
+  - packages/react-native-device-activity/ios/TestHarness/Pods
+  - packages/react-native-device-activity/ios/TestHarness/build

CONTRIBUTING.md

@@ -1,13 +1,57 @@
-# Example project setup
+# Repository development setup
 
-The example project is linked specifically to simplify development. This means it's not looking exactly like the published package, but for most intents and purposes it should result in the same outcome.
+## Example app config (env-driven)
 
-- The config plugin has a `copyToTargetFolder` option that is set to false. This is to prevent the target folder from being copied to the example project and potentially overwriting the original files.
-- The swift files in the targets folder are linked to the root project instead of duplicated. If adding new swift files, try to link them instead of duplicating to keep things clean.
-- The entitlements and info.plist files however duplicated - to not mess with the example project/signing etc.
-- There is a Shared.swift file that can be accessed by all targets. This is linked to each target in the example project, but in the published package it's copied and duplicated to each target. I prefer this to making more changes in @bacons/xcode package which only supports swift files on the root level of each target directory.
-- In addition the example project contains an XCode test target as well as SwiftLint.
+The example app uses `apps/example/app.config.ts` so local developer values do not need to be committed.
 
-## Prebuild
+Create local env values from the template:
 
-To try out prebuild functionality (i.e. the config plugin) run `bun run prebuild` in the example project (it uses the `INTERNALLY_TEST_EXAMPLE_PROJECT` and `COPY_TO_TARGET_FOLDER` env variables to behave like a published package). This should be used to verify changes are expected, but the result should not in it's full state be commited to the example project, since it will break the DX of the example project as explained above.
+```bash
+cp apps/example/.env.example apps/example/.env
+```
+
+Supported variables:
+
+- `RNDA_APPLE_TEAM_ID`
+- `RNDA_APP_GROUP`
+- `RNDA_IOS_BUNDLE_ID`
+- `RNDA_ANDROID_PACKAGE`
+
+If these variables are missing, `app.config.ts` falls back to stable defaults for this repository.
+
+## Example app follows CNG
+
+The example app no longer tracks `apps/example/ios` and `apps/example/android`.
+
+Regenerate native folders when needed:
+
+```bash
+cd apps/example
+bun run prebuild
+# or
+bun run ios
+bun run android
+```
+
+## Swift test ownership
+
+Swift test sources are package-owned and live in:
+
+- `packages/react-native-device-activity/ios/Tests`
+
+The iOS test runner lives in:
+
+- `packages/react-native-device-activity/ios/TestHarness`
+
+## Plugin testing
+
+In addition to app/prebuild validation, config plugin regression tests are defined under:
+
+- `packages/react-native-device-activity/plugin/__tests__`
+
+Run them with:
+
+```bash
+cd packages/react-native-device-activity
+bun run test:plugin
+```

README.md

@@ -583,6 +583,23 @@ For a complete implementation, see the [example app](https://github.com/Kingstin
 
 Contributions are very welcome! Please refer to guidelines described in the [contributing guide](https://github.com/expo/expo#contributing).
 
+### Repository development setup
+
+This repository uses an env-driven Expo example config in `apps/example/app.config.ts` to avoid committing local developer values such as team ID and app group.
+
+Use `apps/example/.env.example` as a template for local values:
+
+- `RNDA_APPLE_TEAM_ID`
+- `RNDA_APP_GROUP`
+- `RNDA_IOS_BUNDLE_ID`
+- `RNDA_ANDROID_PACKAGE`
+
+The example app follows CNG workflow (`expo prebuild --clean` / `expo run:*`) and native folders are generated as needed.
+
+Swift test sources are package-owned in `packages/react-native-device-activity/ios/Tests` and run through the iOS harness in `packages/react-native-device-activity/ios/TestHarness`.
+
+For repository-specific details, see [`CONTRIBUTING.md`](./CONTRIBUTING.md).
+
 ## Weird behaviors ⚠️
 
 - Authorization changes outside app not captured

apps/example/.env.example

@@ -0,0 +1,4 @@
+RNDA_APPLE_TEAM_ID=YOUR_APPLE_TEAM_ID
+RNDA_APP_GROUP=group.your-app-group
+RNDA_IOS_BUNDLE_ID=com.yourcompany.yourapp
+RNDA_ANDROID_PACKAGE=com.yourcompany.yourapp