add clone() method

Author: kinosang

src/Coord.php

@@ -45,7 +45,11 @@ private function gcj02ToWgs84()
             $mglatitude = $this->latitude + $dlatitude;
             $mglongitude = $this->longitude + $dlongitude;
 
-            return new self($this->longitude * 2 - $mglongitude, $this->latitude * 2 - $mglatitude, self::WGS84);
+            $this->longitude = $this->longitude * 2 - $mglongitude;
+            $this->latitude = $this->latitude * 2 - $mglatitude;
+            $this->type = self::WGS84;
+
+            return $this;
         }
     }
 
@@ -65,7 +69,11 @@ private function wgs84ToGcj02()
             $mglatitude = $this->latitude + $dlatitude;
             $mglongitude = $this->longitude + $dlongitude;
 
-            return new self($mglongitude, $mglatitude, self::GCJ02);
+            $this->longitude = $mglongitude;
+            $this->latitude = $mglatitude;
+            $this->type = self::GCJ02;
+
+            return $this;
         }
     }
 
@@ -76,7 +84,11 @@ private function bd09ToGcj02()
         $z = sqrt($x * $x + $y * $y) - 0.00002 * sin($y * self::X_PI);
         $theta = atan2($y, $x) - 0.000003 * cos($x * self::X_PI);
 
-        return new self($z * cos($theta), $z * sin($theta), self::GCJ02);
+        $this->longitude = $z * cos($theta);
+        $this->latitude = $z * sin($theta);
+        $this->type = self::GCJ02;
+
+        return $this;
     }
 
     private function gcj02ToBd09()
@@ -87,7 +99,11 @@ private function gcj02ToBd09()
         $bd_longitude = $z * cos($theta) + 0.0065;
         $bd_latitude = $z * sin($theta) + 0.006;
 
-        return new self($bd_longitude, $bd_latitude, self::BD09);
+        $this->longitude = $bd_longitude;
+        $this->latitude = $bd_latitude;
+        $this->type = self::BD09;
+
+        return $this;
     }
 
     private function bd09ToWgs84()
@@ -120,6 +136,11 @@ private function transformLongitude($longitude, $latitude)
         return $ret;
     }
 
+    public function clone()
+    {
+        return clone $this;
+    }
+
     public function isOutOfChina()
     {
         return ($this->longitude < 72.004 || $this->longitude > 137.8347)
@@ -196,7 +217,7 @@ public function to($type)
 
     public function distanceTo(Coord $destination)
     {
-        $destination = $destination->to($this->type);
+        $destination->to($this->type);
 
         $latitudeRadA = deg2rad($this->latitude);
         $longitudeRadA = deg2rad($this->longitude);

tests/CoordTest.php

@@ -25,33 +25,33 @@ public function testIsOutOfChina()
     public function testTransformFromBd09()
     {
         $coord = new Coord(116.404, 39.915, Coord::BD09);
-        $this->assertEquals('116.39138369951,39.907253214522', $coord->toWgs84());
-        $this->assertEquals('116.39762729119,39.908656739576', $coord->toGcj02());
-        $this->assertEquals($coord, $coord->toBd09());
+        $this->assertEquals('116.39138369951,39.907253214522', $coord->clone()->toWgs84());
+        $this->assertEquals('116.39762729119,39.908656739576', $coord->clone()->toGcj02());
+        $this->assertEquals($coord, $coord->clone()->toBd09());
     }
 
     public function testTransformFromGcj02()
     {
         $coord = new Coord(116.404, 39.915, Coord::GCJ02);
-        $this->assertEquals('116.39775550083,39.913595718498', $coord->toWgs84());
-        $this->assertEquals($coord, $coord->toGcj02());
-        $this->assertEquals('116.41036949371,39.92133699351', $coord->toBd09());
+        $this->assertEquals('116.39775550083,39.913595718498', $coord->clone()->toWgs84());
+        $this->assertEquals($coord, $coord->clone()->toGcj02());
+        $this->assertEquals('116.41036949371,39.92133699351', $coord->clone()->toBd09());
 
         $coord = new Coord(35.765, 140.386, Coord::GCJ02);
-        $this->assertEquals($coord, $coord->toWgs84());
+        $this->assertEquals($coord, $coord->clone()->toWgs84());
     }
 
     public function testTransformFromWgs84()
     {
         $coord = new Coord(116.404, 39.915, Coord::WGS84);
-        $this->assertEquals($coord, $coord->toWgs84());
-        $this->assertEquals('116.41024449917,39.916404281502', $coord->toGcj02());
-        $this->assertEquals('116.41662724379,39.922699552216', $coord->toBd09());
-        $this->assertEquals($coord->toGcj02(), $coord->to(Coord::GCJ02));
-        $this->assertEquals($coord->toBd09(), $coord->to(Coord::BD09));
+        $this->assertEquals($coord, $coord->clone()->toWgs84());
+        $this->assertEquals('116.41024449917,39.916404281502', $coord->clone()->toGcj02());
+        $this->assertEquals('116.41662724379,39.922699552216', $coord->clone()->toBd09());
+        $this->assertEquals($coord->clone()->toGcj02(), $coord->clone()->to(Coord::GCJ02));
+        $this->assertEquals($coord->clone()->toBd09(), $coord->clone()->to(Coord::BD09));
 
         $coord = new Coord(35.765, 140.386, Coord::WGS84);
-        $this->assertEquals($coord, $coord->toGcj02());
+        $this->assertEquals($coord, $coord->clone()->toGcj02());
     }
 
     public function testDistance()