More Codacy fixes

Author: brandonferens

src/Observers/HasManyObserver.php

@@ -16,11 +16,9 @@ public function updating(Model $model, $attribute, $value)
         $childModels = $model->{$attribute}()->get()->all();
 
         for ($i = 0; $i < $count; $i++) {
-            if ($i < count($childModels)) {
-                $childModels[$i]->update($value[$i]);
-            } else {
-                $model->{$attribute}()->create($value[$i]);
-            }
+            $i < count($childModels)
+                ? $childModels[$i]->update($value[$i])
+                : $model->{$attribute}()->create($value[$i]);
         }
 
         if ($count < count($childModels)) {

src/Observers/HasOneObserver.php

@@ -14,11 +14,9 @@ public function updating(Model $model, $attribute, $value)
         $childModel = $model->{$attribute}()->first();
 
         if (! empty($childModel)) {
-            if (count($value)) {
-                $childModel->update($value[0]);
-            } else {
-                $childModel->delete();
-            }
+            count($value)
+                ? $childModel->update($value[0])
+                : $childModel->delete();
         } elseif (count($value)) {
             $model->{$attribute}()->create($value[0]);
         }

tests/Unit/MorphOneTest.php

@@ -110,8 +110,6 @@ public function testFillAttributeForDelete()
         $newEmployee = Employee::create(['name' => 'Test']);
         $newEmployee->summary()->save(Summary::make(['text' => 'summary text']));
 
-        $id = $newEmployee->fresh()->summary->id;
-
         $updateRequest = [
             'name' => 'Test 2',
             'summary' => [