Skip to content

Commit 9d18693

Browse files
committed
Update singular observers to ignore blank values
1 parent c722872 commit 9d18693

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

src/Observers/BelongsToObserver.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,10 @@ public function updating(Model $model, $attribute, $value)
2323
*/
2424
public function creating(Model $model, $attribute, $value)
2525
{
26-
$parentModel = $model->{$attribute}()->getRelated()->newInstance($value[0]);
27-
$parentModel->save();
28-
$model->{$attribute}()->associate($parentModel);
26+
if (count($value)) {
27+
$parentModel = $model->{$attribute}()->getRelated()->newInstance($value[0]);
28+
$parentModel->save();
29+
$model->{$attribute}()->associate($parentModel);
30+
}
2931
}
3032
}

src/Observers/HasOneObserver.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public function updating(Model $model, $attribute, $value)
1919
} else {
2020
$childModel->delete();
2121
}
22-
} else {
22+
} elseif (count($value)) {
2323
$model->{$attribute}()->create($value[0]);
2424
}
2525
}
@@ -29,6 +29,8 @@ public function updating(Model $model, $attribute, $value)
2929
*/
3030
public function created(Model $model, $attribute, $value)
3131
{
32-
$model->{$attribute}()->create($value[0]);
32+
if (count($value)) {
33+
$model->{$attribute}()->create($value[0]);
34+
}
3335
}
3436
}

0 commit comments

Comments
 (0)