Ability to add custom third party integrations

Some refactoring and cleaning up
PHPCS

Author: brandonferens

README.md

@@ -74,6 +74,56 @@ Occasionally you may want to require a child relationship during the creation of
 HasOne::make('Profile', 'profile', Profile::class)->inline()->requireChild(),
 ```
 
+## Support for Third Party Packages
+
+We have included a simple way to address some issues regarding third party packages occasionally not working with Nova Inline Relationships. These packages occasionally handle how they return their subset of fields slightly different. We have a way of easily integrating functionality for these packages. This may not work across the board, but should allow for most third party packages.
+
+You must publish the configs for this package with
+
+```shell script
+php artisan vendor:publish
+```
+
+This will publish a config file as `config/nova-inline-relationships.php`. Add your custom namespaced paths within the `third-party` array. For example:
+
+```php
+'third-party' => [
+    'App\Nova\ThirdPartyIntegrations',
+    'KirschbaumDevelopment\NovaInlineRelationship\Integrations',
+]
+``` 
+
+Create a new class inside that namespace that looks like the following:
+
+```php
+<?php
+
+namespace App\Nova\ThirdPartyIntegrations;
+
+use KirschbaumDevelopment\NovaInlineRelationship\Integrations\ThirdParty;
+use KirschbaumDevelopment\NovaInlineRelationship\Integrations\Contracts\ThirdPartyContract;
+
+class SomeThirdPartyField extends ThirdParty implements ThirdPartyContract
+{
+    /**
+     * Fields array from object.
+     *
+     * @return array
+     */
+    public function fields(): array
+    {
+        // The following is just an example and should be updated to meet your needs.
+        return $this->field->customFieldArray;
+    }
+}
+```
+
+The name of the class is very important. It should be the same name as the field used within the Nova resource. If the field class is `CustomField`, the third party integration class should also be called `CustomField`.
+
+The `fields()` method should return an array of all the custom field's or package's fields array.
+
+If you feel that the third party integration you've created should be included in this package, please create a pull request and we will look over it! 
+
 ## Supported Relationships
 
 The following eloquent relationships are currently supported:

config/config.php

@@ -0,0 +1,7 @@
+<?php
+
+return [
+    'third-party' => [
+        'KirschbaumDevelopment\NovaInlineRelationship\Integrations',
+    ],
+];

src/Exceptions/ContractMissingException.php

@@ -0,0 +1,9 @@
+<?php
+
+namespace KirschbaumDevelopment\NovaInlineRelationship\Exceptions;
+
+use Exception;
+
+class ContractMissingException extends Exception
+{
+}

src/Integrations/Contracts/ThirdPartyContract.php

@@ -7,9 +7,9 @@ interface ThirdPartyContract
     /**
      * ThirdPartyContract constructor.
      *
-     * @param $object
+     * @param $field
      */
-    public function __construct($object);
+    public function __construct($field);
 
     /**
      * Fields array from object.

src/Integrations/Field.php

@@ -4,30 +4,15 @@
 
 use KirschbaumDevelopment\NovaInlineRelationship\Integrations\Contracts\ThirdPartyContract;
 
-class Field implements ThirdPartyContract
+class Field extends ThirdParty implements ThirdPartyContract
 {
-    /**
-     * @var mixed
-     */
-    private $object;
-
-    /**
-     * ThirdPartyContract constructor.
-     *
-     * @param $object
-     */
-    public function __construct($object)
-    {
-        $this->object = $object;
-    }
-
     /**
      * Fields array from object.
      *
      * @return array
      */
     public function fields(): array
     {
-        return [$this->object];
+        return [$this->field];
     }
 }

src/Integrations/Integrate.php

@@ -2,18 +2,33 @@
 
 namespace KirschbaumDevelopment\NovaInlineRelationship\Integrations;
 
-use LeadMarvels\Campaigns\Services\QueryClauses\Contracts\WhereInterface;
+use ReflectionClass;
+use KirschbaumDevelopment\NovaInlineRelationship\Exceptions\ContractMissingException;
 use KirschbaumDevelopment\NovaInlineRelationship\Integrations\Field as FieldInterface;
+use KirschbaumDevelopment\NovaInlineRelationship\Integrations\Contracts\ThirdPartyContract;
 
 class Integrate
 {
-    public static function fields($object): array
+    public static function fields($field): array
     {
-        $basename = class_basename(get_class($object));
-        $class = "\\KirschbaumDevelopment\\NovaInlineRelationship\\Integrations\\{$basename}";
+        $basename = class_basename(get_class($field));
 
-        return class_exists($class)
-            ? (new $class($object))->fields()
-            : (new FieldInterface($object))->fields();
+        foreach (config('nova-inline-relationships.third-party') as $namespace) {
+            $class = "{$namespace}\\{$basename}";
+
+            if (class_exists($class)) {
+                $reflection = new ReflectionClass($class);
+
+                throw_unless(
+                    in_array(ThirdPartyContract::class, $reflection->getInterfaceNames()),
+                    ContractMissingException::class,
+                    sprintf('Third party integration [ %s ] does not implement [ %s ]', $class, ThirdPartyContract::class)
+                );
+
+                return (new $class($field))->fields();
+            }
+        }
+
+        return (new FieldInterface($field))->fields();
     }
 }

src/Integrations/NovaDependencyContainer.php

@@ -4,30 +4,15 @@
 
 use KirschbaumDevelopment\NovaInlineRelationship\Integrations\Contracts\ThirdPartyContract;
 
-class NovaDependencyContainer implements ThirdPartyContract
+class NovaDependencyContainer extends ThirdParty implements ThirdPartyContract
 {
-    /**
-     * @var \Laravel\Nova\Panel
-     */
-    private $object;
-
-    /**
-     * ThirdPartyContract constructor.
-     *
-     * @param $object
-     */
-    public function __construct($object)
-    {
-        $this->object = $object;
-    }
-
     /**
      * Fields array from object.
      *
      * @return array
      */
     public function fields(): array
     {
-        return $this->object->meta['fields'];
+        return $this->field->meta['fields'];
     }
 }

src/Integrations/Panel.php

@@ -4,30 +4,15 @@
 
 use KirschbaumDevelopment\NovaInlineRelationship\Integrations\Contracts\ThirdPartyContract;
 
-class Panel implements ThirdPartyContract
+class Panel extends ThirdParty implements ThirdPartyContract
 {
-    /**
-     * @var \Laravel\Nova\Panel
-     */
-    private $object;
-
-    /**
-     * ThirdPartyContract constructor.
-     *
-     * @param $object
-     */
-    public function __construct($object)
-    {
-        $this->object = $object;
-    }
-
     /**
      * Fields array from object.
      *
      * @return array
      */
     public function fields(): array
     {
-        return $this->object->data;
+        return $this->field->data;
     }
 }

src/Integrations/ThirdParty.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace KirschbaumDevelopment\NovaInlineRelationship\Integrations;
+
+abstract class ThirdParty
+{
+    /**
+     * @var mixed
+     */
+    protected $field;
+
+    /**
+     * ThirdPartyContract constructor.
+     *
+     * @param $field
+     */
+    public function __construct($field)
+    {
+        $this->field = $field;
+    }
+}

src/NovaInlineRelationshipServiceProvider.php

@@ -18,6 +18,12 @@ class NovaInlineRelationshipServiceProvider extends ServiceProvider
      */
     public function boot()
     {
+        if ($this->app->runningInConsole()) {
+            $this->publishes([
+                __DIR__ . '/../config/config.php' => config_path('nova-inline-relationships.php'),
+            ], 'nova-inline-relationships');
+        }
+
         Nova::serving(function (ServingNova $event) {
             Nova::script('nova-inline-relationship', __DIR__ . '/../dist/js/field.js');
             Nova::style('nova-inline-relationship', __DIR__ . '/../dist/css/field.css');
@@ -39,5 +45,6 @@ public function boot()
      */
     public function register()
     {
+        $this->mergeConfigFrom(__DIR__ . '/../config/config.php', 'nova-inline-relationships');
     }
 }