Skip to content

Commit 17e88cb

Browse files
authored
Merge pull request #32 from kiyu-git/feature/ci-serialport-build
feat: CIでarmv7l向けserialportビルドステップを追加
2 parents 635998e + 3aa7cc5 commit 17e88cb

3 files changed

Lines changed: 8 additions & 4 deletions

File tree

.github/workflows/publish-armv7l.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,16 +27,20 @@ jobs:
2727
with:
2828
node-version: 18
2929
cache: npm
30-
30+
3131
- name: Setup Python
3232
uses: actions/setup-python@v2
3333
with:
34-
python-version: '3.10'
34+
python-version: '3.10'
3535

3636
- name: Install and build
3737
run: |
3838
npm install
3939
npm run postinstall
40+
# Build serialport for armv7l
41+
cd release/app/node_modules/@serialport/bindings-cpp
42+
npx node-gyp configure build
43+
cd -
4044
npm run build
4145
4246
- name: Publish releases

src/main/electron-src/lib/serialManager.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ class DataRecorder {
175175
};
176176

177177
stopRecord = () => {
178-
this.shouldRecord = true;
178+
this.shouldRecord = false;
179179
};
180180
}
181181

src/renderer/components/DataPlot.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ export default function DataViewer() {
115115
}
116116
setState(updateLines);
117117
}
118-
}, [newData, state]); // Added state to dependency array
118+
}, [newData]); // Added state to dependency array
119119

120120
return (
121121
<>

0 commit comments

Comments
 (0)