From 31eedf073f34c8b6cf7c4101fa822e10487b0207 Mon Sep 17 00:00:00 2001 From: Vincent Link Date: Wed, 22 Jul 2026 10:03:55 +0200 Subject: [PATCH] Use registry.localhost in e2e CI workflow go-containerregistry PR #2281 (included in v0.21.6) narrowed the insecure HTTP fallback heuristic from *.local to *.localhost only. ko v0.19.0 picked this up via its dependency bump, breaking the e2e workflow's local registry push with: Get "https://registry.local:5000/v2/": http: server gave HTTP response to HTTPS client Rename the registry from registry.local to registry.localhost to match the new heuristic. This aligns with RFC 6761 (*.localhost is the correct domain for loopback services; *.local is mDNS per RFC 6762). Also pass registry-authority to setup-kind so the test job's registry uses the same hostname. Signed-off-by: Vincent Link --- .github/workflows/kind-e2e.yaml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/kind-e2e.yaml b/.github/workflows/kind-e2e.yaml index 15ccca295ee6..22952e0fac9b 100644 --- a/.github/workflows/kind-e2e.yaml +++ b/.github/workflows/kind-e2e.yaml @@ -12,13 +12,13 @@ defaults: shell: bash env: - # https://github.com/google/go-containerregistry/pull/125 allows insecure registry for - # '*.local' hostnames. This works both for `ko` and our own tag-to-digest resolution logic, - # thus allowing us to test without bypassing tag-to-digest resolution. + # go-containerregistry treats '*.localhost' hostnames as insecure (plain HTTP), + # which lets both `ko` and our own tag-to-digest resolution logic work against + # the local registry without TLS. CLUSTER_DOMAIN: c${{ github.run_id }}.local - REGISTRY_NAME: registry.local + REGISTRY_NAME: registry.localhost REGISTRY_PORT: 5000 - KO_DOCKER_REPO: registry.local:5000/knative + KO_DOCKER_REPO: registry.localhost:5000/knative GOTESTSUM_VERSION: 1.12.0 KO_FLAGS: --platform=linux/amd64 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} @@ -182,6 +182,7 @@ jobs: k8s-version: ${{ matrix.k8s-version }} kind-worker-count: 4 cluster-suffix: c${{ github.run_id }}.local + registry-authority: registry.localhost:5000 registry-volume: $HOME/artifacts/registry - name: Install Dependencies