Skip to content

Commit 0d3a694

Browse files
docs: update.
1 parent d2b172d commit 0d3a694

3 files changed

Lines changed: 1 addition & 240 deletions

File tree

.github/prompts/plan-issue62RemainingHardening.prompt.md

Lines changed: 0 additions & 78 deletions
This file was deleted.

docs/issue-62-continuation-prompt.md

Lines changed: 0 additions & 137 deletions
This file was deleted.

docs/next-steps.md

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -19,31 +19,7 @@ Focused follow-up work for `@knighted/develop`.
1919
- Suggested implementation prompt:
2020
- "Add a deterministic E2E execution mode for `@knighted/develop` that serves pinned runtime artifacts locally (instead of live CDN fetches) and wire it into CI as a required check on every PR. Keep a separate lightweight CDN-smoke E2E check for real-network coverage. Validate with `npm run lint`, deterministic Playwright PR checks, and one CDN-smoke Playwright run."
2121

22-
4. **Phase 2 UX/UI continuation: fixed editor tabs first pass (Component, Styles, App)**
23-
- Continue the tabs/editor UX work with a constrained first implementation that supports exactly three editor tabs: Component, Styles, and App.
24-
- Do not introduce arbitrary/custom tab names in this pass; treat custom naming as future scope after baseline tab behavior is stable.
25-
- Preserve existing runtime behavior and editor content semantics while adding tab switching, active tab indication, and predictable persistence/reset behavior consistent with current app patterns.
26-
- Ensure assistant/editor integration remains compatible with this model (edits should target one of the fixed tabs) without expanding to dynamic tab metadata yet.
27-
- Suggested implementation prompt:
28-
- "Implement Phase 2 UX/UI tab support in @knighted/develop with a fixed first-pass tab model: Component, Styles, and App only (no arbitrary tab names yet). Add a clear tab UI for switching editor panes, preserve existing editor behavior/content wiring, and keep render/lint/typecheck/diagnostics flows working with the selected tab context where relevant. Keep AI chat feature-flag behavior unchanged while keeping PR/BYOT controls available by default, maintain CDN-first runtime constraints, and do not add dependencies. Add targeted Playwright coverage for tab switching, default/active tab behavior, and interactions with existing render/style-mode flows. Validate with npm run lint and targeted Playwright tests."
29-
30-
5. **Document implicit App strict-flow behavior (auto render)**
31-
- Add a short behavior matrix in docs that explains when implicit App wrapping is allowed versus when users must define `App` explicitly.
32-
- Include concrete Component editor examples for each case so reviewer/user expectations are clear.
33-
- Suggested example cases to document:
34-
- Allowed implicit wrap (standalone top-level JSX, no imports/declarations), for example:
35-
- `(<button type="button">Standalone</button>) as any`
36-
- Requires explicit `App` (top-level JSX with declarations/imports), for example:
37-
- `const label = 'Hello'`
38-
- `const Button = () => <button>{label}</button>`
39-
- `(<Button />) as any`
40-
- Recommended explicit pattern, for example:
41-
- `const Button = () => <button>Hello</button>`
42-
- `const App = () => <Button />`
43-
- Suggested implementation prompt:
44-
- "Document the current implicit App behavior in @knighted/develop for auto-render mode using a compact behavior matrix and concrete component-editor snippets. Clearly distinguish supported implicit wrapping from cases that intentionally require an explicit App (such as top-level JSX mixed with imports/declarations). Keep docs concise, aligned with current runtime behavior, and include at least one positive and one explicit-error example."
45-
46-
6. **Evaluate GitHub file upsert request strategy (metadata-first vs optimistic PUT)**
22+
4. **Evaluate GitHub file upsert request strategy (metadata-first vs optimistic PUT)**
4723
- Revisit the current metadata-first `upsertRepositoryFile` approach and compare it against an optimistic PUT + targeted retry-on-missing-sha flow.
4824
- Measure tradeoffs for latency, GitHub API request count/rate-limit impact, and browser-console signal quality during common PR flows.
4925
- If beneficial, introduce a configurable/hybrid strategy (for example, optimistic default with metadata fallback) without regressing current reliability.

0 commit comments

Comments
 (0)