Skip to content

Commit 1623e6d

Browse files
feat: github pr context sync with push and close. (#40)
1 parent 0cc37a4 commit 1623e6d

12 files changed

Lines changed: 2128 additions & 160 deletions

docs/next-steps.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,3 +61,10 @@ Focused follow-up work for `@knighted/develop`.
6161
- `const App = () => <Button />`
6262
- Suggested implementation prompt:
6363
- "Document the current implicit App behavior in @knighted/develop for auto-render mode using a compact behavior matrix and concrete component-editor snippets. Clearly distinguish supported implicit wrapping from cases that intentionally require an explicit App (such as top-level JSX mixed with imports/declarations). Keep docs concise, aligned with current runtime behavior, and include at least one positive and one explicit-error example."
64+
65+
7. **Evaluate GitHub file upsert request strategy (metadata-first vs optimistic PUT)**
66+
- Revisit the current metadata-first `upsertRepositoryFile` approach and compare it against an optimistic PUT + targeted retry-on-missing-sha flow.
67+
- Measure tradeoffs for latency, GitHub API request count/rate-limit impact, and browser-console signal quality during common PR flows.
68+
- If beneficial, introduce a configurable/hybrid strategy (for example, optimistic default with metadata fallback) without regressing current reliability.
69+
- Suggested implementation prompt:
70+
- "Evaluate and optionally optimize @knighted/develop GitHub file upsert behavior. Compare metadata-first preflight GET+PUT against optimistic PUT with retry-on-missing-sha for existing files. Keep current reliability guarantees and avoid reintroducing noisy false-positive failures. If implementing a hybrid/configurable strategy, keep defaults conservative, update docs, and validate with npm run lint plus targeted Playwright PR drawer flows."

0 commit comments

Comments
 (0)