Skip to content

Commit ea96187

Browse files
refactor: address pr comments.
1 parent ae47ed0 commit ea96187

6 files changed

Lines changed: 316 additions & 247 deletions

File tree

docs/next-steps.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,3 +25,11 @@ Focused follow-up work for `@knighted/develop`.
2525
- If beneficial, introduce a configurable/hybrid strategy (for example, optimistic default with metadata fallback) without regressing current reliability.
2626
- Suggested implementation prompt:
2727
- "Evaluate and optionally optimize @knighted/develop GitHub file upsert behavior. Compare metadata-first preflight GET+PUT against optimistic PUT with retry-on-missing-sha for existing files. Keep current reliability guarantees and avoid reintroducing noisy false-positive failures. If implementing a hybrid/configurable strategy, keep defaults conservative, update docs, and validate with npm run lint plus targeted Playwright PR drawer flows."
28+
29+
5. **Remove pre-multitab component/styles compatibility paths**
30+
- Delete code paths that preserve or translate legacy single-component/single-styles storage and sync behavior from before the multitab update.
31+
- Remove backward-compatibility shims, fallback field reads, and migration glue tied to old `componentFilePath`/`stylesFilePath`-style assumptions when equivalent tab-derived data exists.
32+
- Favor one canonical tab-first data contract across local storage, IndexedDB workspace records, PR sync metadata, and commit target derivation.
33+
- Accept breaking changes for old locally stored app state to simplify maintenance and reduce branching logic.
34+
- Suggested implementation prompt:
35+
- "Remove backwards-compatibility code in @knighted/develop that supports pre-multitab component/styles storage/sync behavior. Standardize on the current tab-derived schema only, delete legacy field fallbacks and migration helpers, and update tests/docs to match the simplified contract. Validate with npm run lint and targeted Playwright suites for workspace tabs + PR drawer flows."

0 commit comments

Comments
 (0)