test: further.

Author: knightedcodemonkey

README.md

@@ -134,7 +134,7 @@ type ModuleOptions = {
   detectCircularRequires?: 'off' | 'warn' | 'error'
   detectDualPackageHazard?: 'off' | 'warn' | 'error'
   dualPackageHazardScope?: 'file' | 'project'
-  dualPackageHazardAllowlist?: string | string[]
+  dualPackageHazardAllowlist?: string[]
   requireSource?: 'builtin' | 'create-require'
   importMetaPrelude?: 'off' | 'auto' | 'on'
   cjsDefault?: 'module-exports' | 'auto' | 'none'
@@ -163,7 +163,7 @@ type ModuleOptions = {
 - `detectCircularRequires` (`off`): optionally detect relative static require cycles across `.js`/`.mjs`/`.cjs`/`.ts`/`.mts`/`.cts` (realpath-normalized) and warn/throw.
 - `detectDualPackageHazard` (`warn`): flag when `import` and `require` mix for the same package or root/subpath are combined in ways that can resolve to separate module instances (dual packages). Set to `error` to fail the transform.
 - `dualPackageHazardScope` (`file`): `file` preserves the legacy per-file detector; `project` aggregates package usage across all CLI inputs (useful in monorepos/hoisted installs) and emits one diagnostic per package.
-- `dualPackageHazardAllowlist` (`[]`): suppress dual-package hazard diagnostics for the listed packages. Accepts a string or array; entries are trimmed and empty values dropped. Applies to both `file` and `project` scopes and is also available via the CLI flag `--dual-package-hazard-allowlist pkg1,pkg2`.
+- `dualPackageHazardAllowlist` (`[]`): suppress dual-package hazard diagnostics for the listed packages. Accepts an array in the API; entries are trimmed and empty values dropped. The CLI flag `--dual-package-hazard-allowlist pkg1,pkg2` parses a comma- or space-separated string into this array. Applies to both `file` and `project` scopes.
 - `topLevelAwait` (`error`): throw, wrap, or preserve when TLA appears in CommonJS output. `wrap` runs the file body inside an async IIFE (exports may resolve after the initial tick); `preserve` leaves `await` at top level, which Node will reject for CJS.
 - `rewriteSpecifier` (off): rewrite relative specifiers to a chosen extension or via a callback. Precedence: the callback (if provided) runs first; if it returns a string, that wins. If it returns `undefined` or `null`, the appenders still apply.
 - `requireSource` (`builtin`): whether `require` comes from Node or `createRequire`.

test/cli.ts

@@ -227,6 +227,130 @@ test('--dual-package-hazard-allowlist suppresses hazards', async () => {
   }
 })
 
+test('--dual-package-hazard-allowlist parses multiple comma-separated packages', async () => {
+  const temp = await mkdtemp(join(tmpdir(), 'module-cli-dual-hazard-allow-multi-'))
+  const file = join(temp, 'entry.mjs')
+  const packages = ['x-core', 'y-core', 'z-core']
+
+  for (const pkg of packages) {
+    const pkgDir = join(temp, 'node_modules', pkg)
+    await mkdir(pkgDir, { recursive: true })
+    await writeFile(
+      join(pkgDir, 'package.json'),
+      JSON.stringify(
+        {
+          name: pkg,
+          version: '1.0.0',
+          exports: {
+            '.': { import: './index.mjs', require: './index.cjs' },
+            './module': './index.mjs',
+          },
+          main: './index.cjs',
+        },
+        null,
+        2,
+      ),
+      'utf8',
+    )
+  }
+
+  await writeFile(
+    file,
+    [
+      "import { X } from 'x-core/module'",
+      "const core = require('x-core')",
+      "import { Y } from 'y-core/module'",
+      "const y = require('y-core')",
+      "import { Z } from 'z-core/module'",
+      "const z = require('z-core')",
+      'console.log(core, X, y, Y, z, Z)',
+      '',
+    ].join('\n'),
+    'utf8',
+  )
+
+  try {
+    const result = runCli([
+      '--target',
+      'commonjs',
+      '--cwd',
+      temp,
+      '--dual-package-hazard-allowlist',
+      ' x-core , , y-core ',
+      'entry.mjs',
+    ])
+
+    assert.equal(result.status, 0)
+    assert.match(result.stderr, /z-core/)
+    assert.ok(!/x-core/.test(result.stderr))
+    assert.ok(!/y-core/.test(result.stderr))
+  } finally {
+    await rm(temp, { recursive: true, force: true })
+  }
+})
+
+test('--dual-package-hazard-allowlist parses comma-delimited list without spaces', async () => {
+  const temp = await mkdtemp(join(tmpdir(), 'module-cli-dual-hazard-allow-csv-'))
+  const file = join(temp, 'entry.mjs')
+  const packages = ['x-core', 'y-core', 'z-core']
+
+  for (const pkg of packages) {
+    const pkgDir = join(temp, 'node_modules', pkg)
+    await mkdir(pkgDir, { recursive: true })
+    await writeFile(
+      join(pkgDir, 'package.json'),
+      JSON.stringify(
+        {
+          name: pkg,
+          version: '1.0.0',
+          exports: {
+            '.': { import: './index.mjs', require: './index.cjs' },
+            './module': './index.mjs',
+          },
+          main: './index.cjs',
+        },
+        null,
+        2,
+      ),
+      'utf8',
+    )
+  }
+
+  await writeFile(
+    file,
+    [
+      "import { X } from 'x-core/module'",
+      "const core = require('x-core')",
+      "import { Y } from 'y-core/module'",
+      "const y = require('y-core')",
+      "import { Z } from 'z-core/module'",
+      "const z = require('z-core')",
+      'console.log(core, X, y, Y, z, Z)',
+      '',
+    ].join('\n'),
+    'utf8',
+  )
+
+  try {
+    const result = runCli([
+      '--target',
+      'commonjs',
+      '--cwd',
+      temp,
+      '--dual-package-hazard-allowlist',
+      'x-core,y-core',
+      'entry.mjs',
+    ])
+
+    assert.equal(result.status, 0)
+    assert.match(result.stderr, /z-core/)
+    assert.ok(!/x-core/.test(result.stderr))
+    assert.ok(!/y-core/.test(result.stderr))
+  } finally {
+    await rm(temp, { recursive: true, force: true })
+  }
+})
+
 test('--dual-package-hazard-scope project aggregates across files', async () => {
   const temp = await mkdtemp(join(tmpdir(), 'module-cli-dual-hazard-project-'))
   const fileImport = join(temp, 'entry.mjs')

test/module.ts

@@ -165,6 +165,69 @@ describe('@knighted/module', () => {
     assert.equal(diagnostics.length, 0)
   })
 
+  it('supports multi-package allowlists and ignores empty entries', async t => {
+    const temp = await mkdtemp(join(tmpdir(), 'module-dual-hazard-allow-multi-'))
+    const file = join(temp, 'entry.mjs')
+    const packages = ['x-core', 'y-core', 'z-core']
+
+    for (const pkg of packages) {
+      const pkgDir = join(temp, 'node_modules', pkg)
+      await mkdir(pkgDir, { recursive: true })
+      await writeFile(
+        join(pkgDir, 'package.json'),
+        JSON.stringify(
+          {
+            name: pkg,
+            version: '1.0.0',
+            exports: {
+              '.': { import: './index.mjs', require: './index.cjs' },
+              './module': './index.mjs',
+            },
+            main: './index.cjs',
+          },
+          null,
+          2,
+        ),
+        'utf8',
+      )
+    }
+
+    await writeFile(
+      file,
+      [
+        "import { X } from 'x-core/module'",
+        "const core = require('x-core')",
+        "import { Y } from 'y-core/module'",
+        "const y = require('y-core')",
+        "import { Z } from 'z-core/module'",
+        "const z = require('z-core')",
+        'console.log(core, X, y, Y, z, Z)',
+        '',
+      ].join('\n'),
+      'utf8',
+    )
+
+    t.after(() => rm(temp, { recursive: true, force: true }))
+
+    const diagnostics: any[] = []
+    await transform(file, {
+      target: 'commonjs',
+      detectDualPackageHazard: 'warn',
+      dualPackageHazardAllowlist: [' x-core ', '', 'y-core', '   '],
+      diagnostics: diag => diagnostics.push(diag),
+      cwd: temp,
+    })
+
+    assert.ok(
+      diagnostics.length > 0,
+      'expected remaining hazards for non-allowlisted pkg',
+    )
+    assert.ok(diagnostics.every(d => /z-core/.test(d.message)))
+    const codes = new Set(diagnostics.map(d => d.code))
+    assert.ok(codes.has('dual-package-mixed-specifiers'))
+    assert.ok(codes.has('dual-package-conditional-exports'))
+  })
+
   it('warns on hazard across export forms and dynamic import', async t => {
     const temp = await mkdtemp(join(tmpdir(), 'module-dual-hazard-exports-'))
     const file = join(temp, 'entry.mjs')