- tests updated

Author: kodeart

Tests/AcceptLanguageHeaderTest.php

@@ -8,11 +8,10 @@
 class AcceptLanguageHeaderTest extends TestCase
 {
     /**
-     * @dataProvider dataForAsteriskSupport
+     * @dataProvider dataForSupportedLanguagesWithAsterisk
      */
     public function test_match_with_asterisk($accept, $expect, $quality)
     {
-        $this->markTestSkipped('WIP...');
         $negotiator = (new AcceptHeaderNegotiator('*'))->match($accept);
 
         $this->assertSame($expect, $negotiator->value(), 'Expects ' . $expect);
@@ -24,7 +23,6 @@ public function test_match_with_asterisk($accept, $expect, $quality)
      */
     public function test_with_preferred_languages($accept, $expect, $quality)
     {
-        $this->markTestIncomplete('WIP...');
         $negotiator = (new AcceptHeaderNegotiator('de,fr,en'))->match($accept);
 
         $this->assertSame($expect, $negotiator->value(), 'Expects ' . $expect);
@@ -37,7 +35,7 @@ public function test_empty_accept_and_support_headers()
         $this->assertEquals('', $match->value(), 'Empty headers returns empty matched value');
     }
 
-    public function dataForAsteriskSupport()
+    public function dataForSupportedLanguagesWithAsterisk()
     {
         return [
             ['*;q=0.5, fr;q=0.9, en;q=0.8, de;q=0.7', 'fr', 0.9],
@@ -50,7 +48,7 @@ public function dataForSupportedLanguages()
     {
         return [
             ['fr;q=0.7, en;q=0.8, de;q=0.9, *;q=0.5', 'de', 0.9],
-            ['en-US,en;q=0.5', 'en-US', 1.0],
+            ['en-US,en;q=0.5', 'en', 0.5],
             ['*', 'de', 1.0]
         ];
     }

Tests/HeaderTraitTest.php

@@ -40,12 +40,20 @@ public function test_get_header_line()
         $this->assertSame('baz', $response->getHeaderLine('bar'));
     }
 
-    public function test_set_header_line_with_invalid_value()
+    public function test_set_header_line_with_invalid_array_values()
     {
         $this->expectException(\InvalidArgumentException::class);
         $this->expectExceptionCode(HttpStatus::BAD_REQUEST);
         $this->expectExceptionMessage('expects a string or array of strings');
-        $this->SUT->withHeader('foo', [1]);
+        $this->SUT->withHeader('foo', ['bar', 1]);
+    }
+
+     public function test_set_header_line_with_invalid_scalar_value()
+    {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionCode(HttpStatus::BAD_REQUEST);
+        $this->expectExceptionMessage('expects a string or array of strings');
+        $this->SUT->withHeader('foo', 0);
     }
 
     public function test_add_header_value()