Skip to content

Commit f6a9e73

Browse files
committed
The inclusive/exclusive upper bound is not the reason why we have a mismatch in the selectvity between PartOf and inverted PartOf
1 parent 51ded5d commit f6a9e73

2 files changed

Lines changed: 1 addition & 8 deletions

File tree

core/src/annostorage/inmemory.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,9 @@ pub struct AnnoStorageImpl<T: Ord + Hash + Default> {
3232
anno_key_sizes: BTreeMap<AnnoKey, usize>,
3333
anno_keys: SymbolTable<AnnoKey>,
3434
anno_values: SymbolTable<String>,
35+
3536
/// Sampled histograms for each annotation key .
3637
/// Each histogram bound defines a range of values where we estimate that they have the same number of occurences.
37-
///
38-
/// If h_i the the histogram bound value at index i, the first range is defined is as [h_0, h_1), the second range from [h_1, h_2) and so on.
39-
/// Thus each element marks the inclusive start of a range and an exclusive end.
40-
/// **The last range \[h_n-1, h_n\] has an inclusive upper bound instead of an exclusive one!**
4138
histogram_bounds: BTreeMap<usize, Vec<String>>,
4239
largest_item: Option<T>,
4340
total_number_of_annos: usize,

core/src/annostorage/ondisk.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,6 @@ where
5050

5151
/// Sampled histograms for each annotation key .
5252
/// Each histogram bound defines a range of values where we estimate that they have the same number of occurences.
53-
///
54-
/// If h_i the the histogram bound value at index i, the first range is defined is as [h_0, h_1), the second range from [h_1, h_2) and so on.
55-
/// Thus each element marks the inclusive start of a range and an exclusive end.
56-
/// **The last range \[h_n-1, h_n\] has an inclusive upper bound instead of an exclusive one!**
5753
histogram_bounds: BTreeMap<AnnoKey, Vec<String>>,
5854
largest_item: Option<T>,
5955

0 commit comments

Comments
 (0)