Skip to content

Commit 57ca862

Browse files
author
Konstantinos Livieratos
authored
Merge pull request #59 from miguelaferreira/address-linting-warnings
Address linting warnings
2 parents d072f33 + 4a93642 commit 57ca862

2 files changed

Lines changed: 14 additions & 10 deletions

File tree

dockerhub/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,4 @@ RUN wget https://get.helm.sh/helm-v${HELM_VERSION}-linux-amd64.tar.gz -O - | tar
2020
RUN chmod +x /usr/local/bin/helm
2121

2222
COPY entrypoint.sh /entrypoint.sh
23-
ENTRYPOINT ["/entrypoint.sh"]:
23+
ENTRYPOINT ["/entrypoint.sh"]

dockerhub/entrypoint.sh

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,28 @@
1-
#!/bin/sh
1+
#!/bin/bash
22

33
set -e
44

5-
echo ${KUBE_CONFIG_DATA} | base64 -d > kubeconfig
5+
echo "${KUBE_CONFIG_DATA}" | base64 -d > kubeconfig
66
export KUBECONFIG="${PWD}/kubeconfig"
7-
chmod 600 ${PWD}/kubeconfig
7+
chmod 600 "${PWD}/kubeconfig"
88

99
if [[ -n "${INPUT_PLUGINS// /}" ]]
1010
then
11-
plugins=$(echo $INPUT_PLUGINS | tr ",")
11+
plugins="$(echo "${INPUT_PLUGINS}" | tr ",")"
1212

13-
for plugin in $plugins
13+
for plugin in ${plugins}
1414
do
15-
echo "installing helm plugin: [$plugin]"
16-
helm plugin install $plugin
15+
echo "installing helm plugin: [${plugin}]"
16+
helm plugin install "${plugin}"
1717
done
1818
fi
1919

2020
echo "running entrypoint command(s)"
2121

22-
response=$(sh -c " $INPUT_COMMAND")
22+
response=$(bash -c "${INPUT_COMMAND}")
2323

24-
echo "response=$response" >> $GITHUB_OUTPUT
24+
{
25+
echo "response<<EOF";
26+
echo "$response";
27+
echo "EOF";
28+
} >> "${GITHUB_OUTPUT}"

0 commit comments

Comments
 (0)