最適化とC++への置換

Author: tas0dev

kryptinfo.c

@@ -1,60 +1,54 @@
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
+#include <iostream>
+#include <string>
+#include <unordered_map>
+#include <cstdlib>
 
-int main(void)
-{
-    int intanswer;
-    int options; // システムの情報を表示するプログラム
-    char answer[1024]; // コマンドを選ぶ選択肢 char配列なのは数字以外の文字が入力されてもバグを起こさないようにするため
-    char yesno[1024]; // こちらは最後にもう一度選ぶかどうかをyかnで答える
-    do {
-        do {
-            options = 0;
-            // 選択肢を表示
-            fputs("\n\n\n",stdout);
-            printf("1:dmesg as superuser\n2:lsb_release -a\n3:lspci\n4:uname -a\n5:fastfetch");
-            fputs("\n",stdout);
-            //プロンプトを表示
-            printf("選んでください> ");
-            fflush(stdout); // 場合によって表示されないため fflush()を使用
+void executeCommand(const std::string& command) {
+    int result = std::system(command.c_str());
+    if (result != 0) {
+        std::cerr << "Failed to execute the command: " << command << std::endl;
+    }
+}
+
+void displayMenu() {
+    std::cout << "\n\n\n\t==== System info ====" << std::endl;
+    std::cout << "\t1: dmesg as superuser" << std::endl;
+    std::cout << "\t2: lsb_release -a" << std::endl;
+    std::cout << "\t3: lspci" << std::endl;
+    std::cout << "\t4: uname -a" << std::endl;
+    std::cout << "\t5: fastfetch" << std::endl;
+    std::cout << "\t0: exit" << std::endl;
+    std::cout << "\t=====================" << std::endl;
+}
+
+int main() {
+    std::unordered_map<std::string, std::string> commands = {
+        {"1", "sudo dmesg"},
+        {"2", "lsb_release -a"},
+        {"3", "lspci"},
+        {"4", "uname -a"},
+        {"5", "fastfetch"}
+    };
 
-            scanf("%1023s%*[^\n]%*c",answer); // 安全第一
+    std::string choice;
 
-            if (strcmp(answer,"1") == 0 || strcmp(answer,"2") == 0 || strcmp(answer,"3") == 0 || strcmp(answer,"4") == 0 || strcmp(answer,"5") ==0) {
-                ; // Do nothing
-            } else {
-                printf("1~5以外を指定しています\n");
-                options = 1;
-            }
-            } while(options != 0);
-        intanswer = atoi(answer);
-
-        switch(intanswer) {
-            case 1:
-                system("sudo dmesg");
-                break;
-            case 2:
-                system("lsb_release -a");
-                break;
-            case 3:
-                system("lspci");
-                break;
-            case 4:
-                system("uname -a");
-                break;
-            case 5:
-                system("fastfetch");
-                break;
-            default:
-                fputs("Unknown error!! \n",stderr);
-                break;
+    do {
+        displayMenu();
+        std::cout << "> ";
+        std::cin >> choice;
+        
+        if (choice == "0") {
+            std::cout << "\nexit the program." << std::endl;
+            break;
         }
-
-        printf("\n\nもう一度選びますか?(Y or n)> ");
-        scanf("%1023s%*[^\n]%*c",yesno);
-        fputs("\n",stdout);
-    } while(strcmp(yesno,"n"));
-
+        
+        if (commands.find(choice) != commands.end()) {
+            executeCommand(commands[choice]);
+        } else {
+            std::cout << "\nIt is an invalid option. Please specify 1~5 or 0.\n";
+        }
+        
+    } while (true);
+    
     return 0;
 }