Skip to content

Commit 4739b9f

Browse files
Russell King (Oracle)davem330
authored andcommitted
net: pcs: xpcs: remove xpcs_create() from public view
There are now no callers of xpcs_create(), so let's remove it from public view to discourage future direct usage. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent bf9a17b commit 4739b9f

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

drivers/net/pcs/pcs-xpcs.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1224,8 +1224,8 @@ static const struct phylink_pcs_ops xpcs_phylink_ops = {
12241224
.pcs_link_up = xpcs_link_up,
12251225
};
12261226

1227-
struct dw_xpcs *xpcs_create(struct mdio_device *mdiodev,
1228-
phy_interface_t interface)
1227+
static struct dw_xpcs *xpcs_create(struct mdio_device *mdiodev,
1228+
phy_interface_t interface)
12291229
{
12301230
struct dw_xpcs *xpcs;
12311231
u32 xpcs_id;
@@ -1273,7 +1273,6 @@ struct dw_xpcs *xpcs_create(struct mdio_device *mdiodev,
12731273

12741274
return ERR_PTR(ret);
12751275
}
1276-
EXPORT_SYMBOL_GPL(xpcs_create);
12771276

12781277
void xpcs_destroy(struct dw_xpcs *xpcs)
12791278
{

include/linux/pcs/pcs-xpcs.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@ int xpcs_do_config(struct dw_xpcs *xpcs, phy_interface_t interface,
3535
void xpcs_get_interfaces(struct dw_xpcs *xpcs, unsigned long *interfaces);
3636
int xpcs_config_eee(struct dw_xpcs *xpcs, int mult_fact_100ns,
3737
int enable);
38-
struct dw_xpcs *xpcs_create(struct mdio_device *mdiodev,
39-
phy_interface_t interface);
4038
struct dw_xpcs *xpcs_create_mdiodev(struct mii_bus *bus, int addr,
4139
phy_interface_t interface);
4240
void xpcs_destroy(struct dw_xpcs *xpcs);

0 commit comments

Comments
 (0)