Skip to content

Commit 5541577

Browse files
pmachatakuba-moo
authored andcommitted
selftests: mlxsw: vxlan: Disable IPv6 autogen on bridges
In a future patch, mlxsw will start adding RIFs to uppers of front panel port netdevices, if they have an IP address. At the time that the front panel port is enslaved to the bridge (this holds for all bridges used here), the bridge MAC address does not have the same prefix as other interfaces in the system. On Nvidia Spectrum-1 machines all the RIFs have to have the same 38-bit MAC address prefix. Since the bridge does not obey this limitation, the RIF cannot be created, and the enslavement attempt is vetoed on the grounds of the configuration not being offloadable. The selftest itself however checks various aspects of VXLAN offloading and the bridges do not need to participate in routing traffic. The IP addresses or the RIFs are irrelevant. Fix by disabling automatic IPv6 address generation for the HW-offloaded bridges in this selftest, thus exempting them from mlxsw router attention. Signed-off-by: Petr Machata <petrm@nvidia.com> Reviewed-by: Danielle Ratson <danieller@nvidia.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 08035d8 commit 5541577

1 file changed

Lines changed: 31 additions & 10 deletions

File tree

  • tools/testing/selftests/drivers/net/mlxsw

tools/testing/selftests/drivers/net/mlxsw/vxlan.sh

Lines changed: 31 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -444,8 +444,12 @@ offload_indication_setup_create()
444444
{
445445
# Create a simple setup with two bridges, each with a VxLAN device
446446
# and one local port
447-
ip link add name br0 up type bridge mcast_snooping 0
448-
ip link add name br1 up type bridge mcast_snooping 0
447+
ip link add name br0 type bridge mcast_snooping 0
448+
ip link set dev br0 addrgenmode none
449+
ip link set dev br0 up
450+
ip link add name br1 type bridge mcast_snooping 0
451+
ip link set dev br1 addrgenmode none
452+
ip link set dev br1 up
449453

450454
ip link set dev $swp1 master br0
451455
ip link set dev $swp2 master br1
@@ -646,8 +650,12 @@ offload_indication_decap_route_test()
646650

647651
RET=0
648652

649-
ip link add name br0 up type bridge mcast_snooping 0
650-
ip link add name br1 up type bridge mcast_snooping 0
653+
ip link add name br0 type bridge mcast_snooping 0
654+
ip link set dev br0 addrgenmode none
655+
ip link set dev br0 up
656+
ip link add name br1 type bridge mcast_snooping 0
657+
ip link set dev br1 addrgenmode none
658+
ip link set dev br1 up
651659
ip link set dev $swp1 master br0
652660
ip link set dev $swp2 master br1
653661
ip link set dev vxlan0 master br0
@@ -780,7 +788,9 @@ __offload_indication_join_vxlan_first()
780788

781789
offload_indication_join_vxlan_first()
782790
{
783-
ip link add dev br0 up type bridge mcast_snooping 0
791+
ip link add dev br0 type bridge mcast_snooping 0
792+
ip link set dev br0 addrgenmode none
793+
ip link set dev br0 up
784794
ip link add name vxlan0 up type vxlan id 10 nolearning $UDPCSUM_FLAFS \
785795
ttl 20 tos inherit local $LOCAL_IP_1 dstport 4789
786796

@@ -815,7 +825,9 @@ __offload_indication_join_vxlan_last()
815825

816826
offload_indication_join_vxlan_last()
817827
{
818-
ip link add dev br0 up type bridge mcast_snooping 0
828+
ip link add dev br0 type bridge mcast_snooping 0
829+
ip link set dev br0 addrgenmode none
830+
ip link set dev br0 up
819831
ip link add name vxlan0 up type vxlan id 10 nolearning $UDPCSUM_FLAFS \
820832
ttl 20 tos inherit local $LOCAL_IP_1 dstport 4789
821833

@@ -842,6 +854,7 @@ sanitization_vlan_aware_test()
842854
RET=0
843855

844856
ip link add dev br0 type bridge mcast_snooping 0 vlan_filtering 1
857+
ip link set dev br0 addrgenmode none
845858

846859
ip link add name vxlan10 up master br0 type vxlan id 10 nolearning \
847860
$UDPCSUM_FLAFS ttl 20 tos inherit local $LOCAL_IP_1 dstport 4789
@@ -915,8 +928,10 @@ offload_indication_vlan_aware_setup_create()
915928
{
916929
# Create a simple setup with two VxLAN devices and a single VLAN-aware
917930
# bridge
918-
ip link add name br0 up type bridge mcast_snooping 0 vlan_filtering 1 \
931+
ip link add name br0 type bridge mcast_snooping 0 vlan_filtering 1 \
919932
vlan_default_pvid 0
933+
ip link set dev br0 addrgenmode none
934+
ip link set dev br0 up
920935

921936
ip link set dev $swp1 master br0
922937

@@ -1060,8 +1075,10 @@ offload_indication_vlan_aware_decap_route_test()
10601075

10611076
offload_indication_vlan_aware_join_vxlan_first()
10621077
{
1063-
ip link add dev br0 up type bridge mcast_snooping 0 \
1078+
ip link add dev br0 type bridge mcast_snooping 0 \
10641079
vlan_filtering 1 vlan_default_pvid 1
1080+
ip link set dev br0 addrgenmode none
1081+
ip link set dev br0 up
10651082
ip link add name vxlan0 up type vxlan id 10 nolearning $UDPCSUM_FLAFS \
10661083
ttl 20 tos inherit local $LOCAL_IP_1 dstport 4789
10671084

@@ -1073,8 +1090,10 @@ offload_indication_vlan_aware_join_vxlan_first()
10731090

10741091
offload_indication_vlan_aware_join_vxlan_last()
10751092
{
1076-
ip link add dev br0 up type bridge mcast_snooping 0 \
1093+
ip link add dev br0 type bridge mcast_snooping 0 \
10771094
vlan_filtering 1 vlan_default_pvid 1
1095+
ip link set dev br0 addrgenmode none
1096+
ip link set dev br0 up
10781097
ip link add name vxlan0 up type vxlan id 10 nolearning $UDPCSUM_FLAFS \
10791098
ttl 20 tos inherit local $LOCAL_IP_1 dstport 4789
10801099

@@ -1091,8 +1110,10 @@ offload_indication_vlan_aware_l3vni_test()
10911110
RET=0
10921111

10931112
sysctl_set net.ipv6.conf.default.disable_ipv6 1
1094-
ip link add dev br0 up type bridge mcast_snooping 0 \
1113+
ip link add dev br0 type bridge mcast_snooping 0 \
10951114
vlan_filtering 1 vlan_default_pvid 0
1115+
ip link set dev br0 addrgenmode none
1116+
ip link set dev br0 up
10961117
ip link add name vxlan0 up type vxlan id 10 nolearning $UDPCSUM_FLAFS \
10971118
ttl 20 tos inherit local $LOCAL_IP_1 dstport 4789
10981119

0 commit comments

Comments
 (0)