Skip to content

Commit 5ac1888

Browse files
donaldhkuba-moo
authored andcommitted
tools: ynl: Initialise fixed headers to 0 in genetlink-legacy
This eliminates the need for e.g. --json '{"dp-ifindex":0}' which is not too big a deal for ovs but will get tiresome for fixed header structs that have many members. Signed-off-by: Donald Hunter <donald.hunter@gmail.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 6d6bae6 commit 5ac1888

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tools/net/ynl/lib/ynl.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,7 @@ def _op(self, method, vals, dump=False):
541541
if op.fixed_header:
542542
fixed_header_members = self.consts[op.fixed_header].members
543543
for m in fixed_header_members:
544-
value = vals.pop(m.name)
544+
value = vals.pop(m.name) if m.name in vals else 0
545545
format = NlAttr.get_format(m.type, m.byte_order)
546546
msg += format.pack(value)
547547
for name, value in vals.items():

0 commit comments

Comments
 (0)