Skip to content

Commit c7cfbd1

Browse files
peilin-yekuba-moo
authored andcommitted
net/sched: sch_ingress: Only create under TC_H_INGRESS
ingress Qdiscs are only supposed to be created under TC_H_INGRESS. Return -EOPNOTSUPP if 'parent' is not TC_H_INGRESS, similar to mq_init(). Fixes: 1da177e ("Linux-2.6.12-rc2") Reported-by: syzbot+b53a9c0d1ea4ad62da8b@syzkaller.appspotmail.com Closes: https://lore.kernel.org/r/0000000000006cf87705f79acf1a@google.com/ Tested-by: Pedro Tammela <pctammela@mojatatu.com> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com> Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com> Reviewed-by: Vlad Buslov <vladbu@nvidia.com> Signed-off-by: Peilin Ye <peilin.ye@bytedance.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 7ba0732 commit c7cfbd1

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

net/sched/sch_ingress.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,9 @@ static int ingress_init(struct Qdisc *sch, struct nlattr *opt,
8080
struct net_device *dev = qdisc_dev(sch);
8181
int err;
8282

83+
if (sch->parent != TC_H_INGRESS)
84+
return -EOPNOTSUPP;
85+
8386
net_inc_ingress_queue();
8487

8588
mini_qdisc_pair_init(&q->miniqp, sch, &dev->miniq_ingress);
@@ -101,6 +104,9 @@ static void ingress_destroy(struct Qdisc *sch)
101104
{
102105
struct ingress_sched_data *q = qdisc_priv(sch);
103106

107+
if (sch->parent != TC_H_INGRESS)
108+
return;
109+
104110
tcf_block_put_ext(q->block, sch, &q->block_info);
105111
net_dec_ingress_queue();
106112
}

0 commit comments

Comments
 (0)