selftests/bpf: Fix u32 variable compared with less than zero

kangtegong · Martin KaFai Lau · commit e8f50c4f0c14 · 2022-11-07T16:53:50.000-08:00
Variable ret is compared with less than zero even though it was set as u32. So u32 to int conversion is needed. Signed-off-by: Kang Minchul <tegongkang@gmail.com> Acked-by: Randy Dunlap <rdunlap@infradead.org> Acked-by: Björn Töpel <bjorn@kernel.org> Link: https://lore.kernel.org/r/20221105183656.86077-1-tegongkang@gmail.com Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
diff --git a/tools/testing/selftests/bpf/xskxceiver.c b/tools/testing/selftests/bpf/xskxceiver.c
@@ -1006,7 +1006,8 @@ static int __send_pkts(struct ifobject *ifobject, u32 *pkt_nb, struct pollfd *fd
 {
 	struct xsk_socket_info *xsk = ifobject->xsk;
 	bool use_poll = ifobject->use_poll;
-	u32 i, idx = 0, ret, valid_pkts = 0;
+	u32 i, idx = 0, valid_pkts = 0;
+	int ret;
 
 	while (xsk_ring_prod__reserve(&xsk->tx, BATCH_SIZE, &idx) < BATCH_SIZE) {
 		if (use_poll) {

Original file line number	Diff line number	Diff line change
`@@ -1006,7 +1006,8 @@ static int __send_pkts(struct ifobject ifobject, u32 pkt_nb, struct pollfd *fd`
`1006`	`1006`	`{`
`1007`	`1007`	`struct xsk_socket_info *xsk = ifobject->xsk;`
`1008`	`1008`	`bool use_poll = ifobject->use_poll;`
`1009`		`- u32 i, idx = 0, ret, valid_pkts = 0;`
	`1009`	`+ u32 i, idx = 0, valid_pkts = 0;`
	`1010`	`+ int ret;`
`1010`	`1011`
`1011`	`1012`	`while (xsk_ring_prod__reserve(&xsk->tx, BATCH_SIZE, &idx) < BATCH_SIZE) {`
`1012`	`1013`	`if (use_poll) {`