feat(): add HA Kustomize overlay configuration#488
Open
Maximus-08 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Avnish Jaltare <avnishjaltare8@gmail.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a high-availability (HA) kustomize overlay for the operator by increasing replica count, spreading pods across nodes, and introducing a PodDisruptionBudget.
Changes:
- Added a PodDisruptionBudget to limit voluntary disruptions.
- Added a Deployment patch to run 2 replicas with pod anti-affinity preferences.
- Added an HA kustomization overlay that composes default manifests plus HA-specific resources/patches.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| config/ha/pdb.yaml | Adds a PodDisruptionBudget intended to protect operator pods during disruptions. |
| config/ha/manager_ha_patch.yaml | Patches the operator Deployment to 2 replicas and adds preferred pod anti-affinity. |
| config/ha/kustomization.yaml | Defines the HA overlay composition (base + PDB + strategic merge patch). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Avnish Jaltare <avnishjaltare8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Lays the foundation for running a high-availability
worker-operatorto prevent single-point-of-failure scenarios, aligning with the KubeSlice HA proposal.This introduces a dedicated HA Kustomize overlay that allows compiling multi-replica configurations without altering the default single-replica setup.
Proposed Changes:
config/ha/kustomization.yaml: Standard Kustomization base chaining resources and merge patches.config/ha/manager_ha_patch.yaml: Strategic merge patch to scale theoperatordeployment to 2 replicas and adds preferred pod anti-affinity based on thekubernetes.io/hostnametopology key to ensure operator pods are scheduled on distinct nodes.config/ha/pdb.yaml: Introduces aPodDisruptionBudgetfor the worker manager requiringminAvailable: 1to guarantee high availability during cluster maintenance or node drains.Fixes #
How Has This Been Tested?
Tested locally by building the Kustomize overlay to verify that the strategic merge patches compile successfully and output the correct resources, replicas, and pod anti-affinity constraints.
Test Cases
kustomize build config/hato verify successful manifest compilation.Checklist:
go fmtDoes this PR introduce a breaking change?