Ditch rubocop (#92)

Fixes #91

rubocop has its own LSP. Stop wrestling with it. It was never worth the effort anyway.

Author: kwerle

.rubocop.yml

@@ -19,6 +19,12 @@ AllCops:
   Exclude:
     - 'spec/fixture_files/**/*'
 
+Gemspec/DependencyVersion:
+  Enabled: false
+
+Gemspec/DevelopmentDependencies:
+  Enabled: false
+
 Layout/SpaceInsideHashLiteralBraces:
   Enabled: false
 
@@ -152,23 +158,19 @@ Style/GuardClause:
 Style/HashSyntax:
   Exclude:
     - 'lib/ruby_language_server/location.rb'
-    - 'spec/lib/ruby_language_server/good_cop_spec.rb'
 
 # Cop supports --auto-correct.
 # Configuration parameters: IgnoredMethods.
 Style/MethodCallWithoutArgsParentheses:
   Exclude:
     - 'lib/ruby_language_server/scope_parser.rb'
-    - 'spec/lib/ruby_language_server/good_cop_spec.rb'
 
 Style/MultilineBlockChain:
   Exclude:
-    - 'lib/ruby_language_server/good_cop.rb'
 
 # Cop supports --auto-correct.
 Style/MutableConstant:
   Exclude:
-    - 'lib/ruby_language_server/good_cop.rb'
     - 'lib/ruby_language_server/scope_data/base.rb'
     - 'lib/ruby_language_server/version.rb'
 
@@ -222,7 +224,6 @@ Style/StringLiterals:
     - 'lib/ruby_language_server/scope_parser.rb'
     - 'spec/lib/ruby_language_server/code_file_spec.rb'
     - 'spec/lib/ruby_language_server/completion_spec.rb'
-    - 'spec/lib/ruby_language_server/good_cop_spec.rb'
     - 'spec/lib/ruby_language_server/line_context_spec.rb'
     - 'spec/lib/ruby_language_server/scope_parser_spec.rb'
 

Gemfile.lock

@@ -8,44 +8,59 @@ PATH
       etc
       fuzzy_match
       json
-      rubocop (> 1.38.0)
-      rubocop-ast (> 1.32.0)
-      rubocop-performance
-      rubocop-rspec
-      sqlite3 (< 1.5.0)
+      ostruct
+      sqlite3
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (7.0.7.2)
-      activesupport (= 7.0.7.2)
-    activerecord (7.0.7.2)
-      activemodel (= 7.0.7.2)
-      activesupport (= 7.0.7.2)
-    activesupport (7.0.7.2)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
+    activemodel (7.2.2.1)
+      activesupport (= 7.2.2.1)
+    activerecord (7.2.2.1)
+      activemodel (= 7.2.2.1)
+      activesupport (= 7.2.2.1)
+      timeout (>= 0.4.0)
+    activesupport (7.2.2.1)
+      base64
+      benchmark (>= 0.3)
+      bigdecimal
+      concurrent-ruby (~> 1.0, >= 1.3.1)
+      connection_pool (>= 2.2.5)
+      drb
       i18n (>= 1.6, < 2)
+      logger (>= 1.4.2)
       minitest (>= 5.1)
-      tzinfo (~> 2.0)
+      securerandom (>= 0.3)
+      tzinfo (~> 2.0, >= 2.0.5)
     amatch (0.4.1)
       mize
       tins (~> 1.0)
     ansi (1.5.0)
-    ast (2.4.2)
-    builder (3.2.4)
-    byebug (11.1.3)
+    ast (2.4.3)
+    base64 (0.2.0)
+    benchmark (0.4.0)
+    bigdecimal (3.1.9)
+    builder (3.3.0)
     coderay (1.1.3)
-    concurrent-ruby (1.2.2)
-    etc (1.3.0)
-    ffi (1.15.5)
+    concurrent-ruby (1.3.5)
+    connection_pool (2.5.3)
+    debug (1.10.0)
+      irb (~> 1.10)
+      reline (>= 0.3.8)
+    drb (2.2.1)
+    etc (1.4.5)
+    ffi (1.17.2-aarch64-linux-musl)
+    ffi (1.17.2-x86_64-linux-gnu)
     formatador (1.1.0)
     fuzzy_match (2.1.0)
-    guard (2.18.0)
+    guard (2.19.1)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
+      logger (~> 1.6)
       lumberjack (>= 1.0.12, < 2.0)
       nenv (~> 0.1)
       notiffany (~> 0.0)
+      ostruct (~> 0.6)
       pry (>= 0.13.0)
       shellany (~> 0.0)
       thor (>= 0.18.1)
@@ -56,93 +71,118 @@ GEM
     guard-rubocop (1.5.0)
       guard (~> 2.0)
       rubocop (< 2.0)
-    i18n (1.14.1)
+    i18n (1.14.7)
       concurrent-ruby (~> 1.0)
-    json (2.6.2)
-    listen (3.7.1)
+    io-console (0.7.1)
+    irb (1.13.1)
+      rdoc (>= 4.0.0)
+      reline (>= 0.4.2)
+    json (2.11.3)
+    language_server-protocol (3.17.0.4)
+    lint_roller (1.1.0)
+    listen (3.9.0)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
-    lumberjack (1.2.8)
-    method_source (1.0.0)
-    minitest (5.16.3)
-    minitest-reporters (1.5.0)
+    logger (1.7.0)
+    lumberjack (1.2.10)
+    method_source (1.1.0)
+    minitest (5.25.5)
+    minitest-reporters (1.7.1)
       ansi
       builder
       minitest (>= 5.0)
       ruby-progressbar
-    mize (0.4.0)
-      protocol (~> 2.0)
+    mize (0.6.1)
     nenv (0.3.0)
     notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    parallel (1.22.1)
-    parser (3.3.4.2)
+    ostruct (0.6.1)
+    parallel (1.27.0)
+    parser (3.3.8.0)
       ast (~> 2.4.1)
       racc
-    protocol (2.0.0)
-      ruby_parser (~> 3.0)
-    pry (0.14.1)
+    prism (1.4.0)
+    pry (0.15.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
+    psych (5.1.2)
+      stringio
     racc (1.8.1)
     rainbow (3.1.1)
-    rake (13.0.6)
+    rake (13.2.1)
     rb-fsevent (0.11.2)
-    rb-inotify (0.10.1)
+    rb-inotify (0.11.1)
       ffi (~> 1.0)
-    regexp_parser (2.6.0)
-    rexml (3.3.9)
-    rubocop (1.42.0)
+    rdoc (6.6.3.1)
+      psych (>= 4.0.0)
+    regexp_parser (2.10.0)
+    reline (0.5.10)
+      io-console (~> 0.5)
+    rubocop (1.75.5)
       json (~> 2.3)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
-      parser (>= 3.1.2.1)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.24.1, < 2.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.44.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.32.1)
-      parser (>= 3.3.1.0)
-    rubocop-minitest (0.34.5)
-      rubocop (>= 1.39, < 2.0)
-      rubocop-ast (>= 1.30.0, < 2.0)
-    rubocop-performance (1.19.1)
-      rubocop (>= 1.7.0, < 2.0)
-      rubocop-ast (>= 0.4.0)
-    rubocop-rake (0.6.0)
-      rubocop (~> 1.0)
-    rubocop-rspec (3.0.0)
-      rubocop (~> 1.40)
-    ruby-progressbar (1.11.0)
-    ruby_parser (3.19.1)
-      sexp_processor (~> 4.16)
-    sexp_processor (4.16.1)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.44.1)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
+    rubocop-minitest (0.38.0)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-performance (1.25.0)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-rake (0.7.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1)
+    rubocop-rspec (3.6.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    ruby-progressbar (1.13.0)
+    securerandom (0.4.1)
     shellany (0.0.1)
-    sqlite3 (1.4.4)
+    sqlite3 (2.6.0-aarch64-linux-musl)
+    sqlite3 (2.6.0-x86_64-linux-gnu)
+    stringio (3.1.1)
     sync (0.5.0)
-    thor (1.2.1)
-    tins (1.31.1)
+    thor (1.3.2)
+    timeout (0.4.3)
+    tins (1.38.0)
+      bigdecimal
       sync
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.3.0)
+    unicode-display_width (3.1.4)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
 
 PLATFORMS
   aarch64-linux-musl
   x86_64-linux
 
 DEPENDENCIES
-  byebug
+  debug
   guard
   guard-minitest
   guard-rubocop
   minitest
   minitest-reporters
   rake
+  rubocop (> 1.38.0)
+  rubocop-ast (> 1.32.0)
   rubocop-minitest
+  rubocop-performance
   rubocop-rake
+  rubocop-rspec
   ruby_language_server!
 
 BUNDLED WITH

Guardfile

@@ -25,7 +25,7 @@ group :red_green_refactor, halt_on_fail: true do
     # watch(%r{^test/test_helper\.rb$})      { 'test' }
 
     # with Minitest::Spec
-    watch(%r{^spec/**/(.*)_spec\.rb$})
+    watch(%r{^spec/*/(.*)_spec\.rb$})
     watch(%r{^lib/(.+)\.rb$})          { |m| "spec/lib/#{m[1]}_spec.rb" }
     watch(%r{^spec/spec_helper\.rb$})  { 'spec' }
   end

lib/config/initializers/active_record.rb

@@ -7,7 +7,7 @@
   timeout: 30.seconds # does not seem to help
 )
 
-database = ActiveRecord::Base.connection.instance_variable_get :@connection
+database = ActiveRecord::Base.connection.raw_connection
 database.enable_load_extension(1)
 if Gem.win_platform?
   # load DLL from PATH

lib/resources/fallback_rubocop.yml

@@ -13,7 +13,6 @@
 require_relative 'location'
 require_relative 'code_file'
 require_relative 'scope_parser'
-require_relative 'good_cop'
 require_relative 'project_manager'
 require_relative 'server'
 require_relative 'line_context'