Fixed texture downloading

Author: emyfops

common/src/main/kotlin/com/lambda/graphics/texture/TextureUtils.kt

@@ -71,6 +71,18 @@ object TextureUtils {
         glPixelStorei(GL_UNPACK_ALIGNMENT, 4)
     }
 
+    fun readImage(
+        bytes: ByteArray,
+        format: NativeImage.Format = NativeImage.Format.RGBA,
+    ): NativeImage {
+        val buffer = BufferUtils
+            .createByteBuffer(bytes.size)
+            .put(bytes)
+            .flip()
+
+        return NativeImage.read(format, buffer)
+    }
+
     fun readImage(
         bufferedImage: BufferedImage,
         format: NativeImage.Format = NativeImage.Format.RGBA,

common/src/main/kotlin/com/lambda/network/CapeManager.kt

@@ -18,7 +18,6 @@
 package com.lambda.network
 
 import com.github.kittinunf.fuel.core.FuelError
-import com.lambda.Lambda.LOG
 import com.lambda.Lambda.mc
 import com.lambda.context.SafeContext
 import com.lambda.core.Loadable
@@ -56,7 +55,10 @@ object CapeManager : ConcurrentHashMap<UUID, String>(), Loadable {
     fun SafeContext.fetch(uuid: UUID) = getOrPut(uuid) {
         getCape(uuid)
             .fold(
-                success = { if (!images.contains(it.cape)) it.fetch(); put(uuid, it.cape) },
+                success = {
+                    if (!images.contains(it.cape)) it.fetch()
+                    put(uuid, it.cape)
+                },
                 failure = { throw it },
             )
     }
@@ -65,8 +67,7 @@ object CapeManager : ConcurrentHashMap<UUID, String>(), Loadable {
 
     init {
         listen<WorldEvent.Player.Join>(alwaysListen = true) {
-            runCatching { fetch(it.uuid) }
-                .onFailure { LOG.error(it) }
+            fetch(it.uuid)
         }
     }
 }

common/src/main/kotlin/com/lambda/network/api/v1/models/Cape.kt

@@ -19,12 +19,16 @@ package com.lambda.network.api.v1.models
 
 import com.github.kittinunf.fuel.Fuel
 import com.google.gson.annotations.SerializedName
+import com.lambda.graphics.texture.TextureUtils
 import com.lambda.sound.SoundManager.toIdentifier
 import com.lambda.threading.runSafe
+import com.lambda.util.Communication.logError
 import com.lambda.util.FolderRegister.capes
 import com.lambda.util.extension.resolveFile
 import net.minecraft.client.texture.NativeImage
 import net.minecraft.client.texture.NativeImageBackedTexture
+import org.lwjgl.BufferUtils
+import java.io.BufferedOutputStream
 import java.io.ByteArrayOutputStream
 
 class Cape(
@@ -35,20 +39,19 @@ class Cape(
     val cape: String,
 ) {
     fun fetch() = runSafe {
-        val output = ByteArrayOutputStream(2048*1024*4)
-
         Fuel.download(url)
-            .streamDestination { _, request -> output to { request.body.toStream() } }
-
-        val image = NativeImage.read(output.toByteArray())
-        val native = NativeImageBackedTexture(image)
-        val id = cape.toIdentifier()
-
-        mc.textureManager.registerTexture(id, native)
-
-        capes.resolveFile("$cape.png")
-            .writeBytes(output.toByteArray())
+            .fileDestination { _, _ -> capes.resolveFile("$cape.png") }
+            .response { result ->
+                result.fold(
+                    success = {
+                        val image = TextureUtils.readImage(it)
+                        val native = NativeImageBackedTexture(image)
+                        val id = cape.toIdentifier()
+
+                        mc.textureManager.registerTexture(id, native)
+                    },
+                    failure = { logError("Error while downloading capes", it) }
+                )
+            }
     }
-
-    fun identifier() = cape.toIdentifier()
 }