[REL-11803] removing the php and javascript targets (#294)

removing the php and javascript targets

Author: bwoskow-ld

.github/workflows/ci.yml

@@ -85,32 +85,6 @@ jobs:
         run: |
           cd samples/go
           make
-  test-javascript:
-    runs-on: ubuntu-latest
-    needs: build
-    steps:
-      - uses: actions/checkout@v4
-      - name: Download targets
-        uses: actions/download-artifact@v4
-        with:
-          name: targets
-          path: targets
-      - uses: actions/setup-node@v4
-        with:
-          node-version: '20'
-      - name: Build JS client
-        working-directory: targets/api-client-javascript
-        run: |
-          rm -rf node_modules dist
-          npm install
-          npx --yes babel src -d dist --plugins @babel/plugin-transform-modules-commonjs
-      # TODO: Fix this test
-      # - name: Run JS sample
-      #   run: |
-      #     cd samples/javascript
-      #     # Install the local package directly
-      #     npm install
-      #     node index.js
   test-python:
     runs-on: ubuntu-latest
     needs: build
@@ -212,37 +186,16 @@ jobs:
           npm install
           npm run build
           npm start
-  test-php:
-    runs-on: ubuntu-latest
-    needs: build
-    steps:
-      - uses: actions/checkout@v4
-      - name: Download targets
-        uses: actions/download-artifact@v4
-        with:
-          name: targets
-          path: targets
-      - uses: shivammathur/setup-php@v2
-        with:
-            php-version: '8.1'
-      - name: Run PHP sample
-        working-directory: samples/php
-        run: |
-            echo '{"require":{"launchdarkly/api-client-php":"@dev","guzzlehttp/guzzle":"*"},"repositories":[{"type":"path","url":"../../targets/api-client-php","options":{"symlink":true}}]}' > composer.json
-            composer update
-            php index.php
 
   check-success:
     name: Check Success
     needs:
       - build
       - test-go
-      - test-javascript
       - test-python
       - test-ruby
       - test-java
       - test-typescript
-      - test-php
     if: always()
     runs-on: ubuntu-latest
     steps:

.github/workflows/release.yml

@@ -59,7 +59,7 @@ jobs:
           java -XX:+PrintFlagsFinal -version | grep ThreadStackSize
           make
           # Verify that the generated client code can be built
-          make BUILD_TARGETS="go java javascript python ruby typescript-axios" build_clients
+          make BUILD_TARGETS="go java python ruby typescript-axios" build_clients
         # This step will:
         # * Push built clients to their respective Github repos
         # * Tag those commits with the release version
@@ -77,7 +77,7 @@ jobs:
     needs: release
     strategy:
       matrix:
-        repo: ['api-client-go', 'api-client-java', 'api-client-javascript', 'api-client-php', 'api-client-python', 'api-client-ruby', 'api-client-typescript']
+        repo: ['api-client-go', 'api-client-java', 'api-client-python', 'api-client-ruby', 'api-client-typescript']
     steps:
       - uses: ncipollo/release-action@v1.14.0
         with:

.ldrelease/build.sh

@@ -19,8 +19,6 @@ LATEST_API_VERSION=20240415 # the API version (for the LD-API-Version header val
 API_TARGETS ?= \
 	go \
 	java \
-	javascript \
-	php \
 	python \
 	ruby \
 	typescript-axios
@@ -81,19 +79,6 @@ CODEGEN_PARAMS_java = \
 	--additional-properties=scmDeveloperConnection='scm:git:ssh:git@github.com:launchdarkly/api-client-java.git' \
 	--additional-properties=gradleProperties=systemProp.org.gradle.internal.http.connectionTimeout=300000$$'\n'systemProp.org.gradle.internal.http.socketTimeout=300000$$'\n'org.gradle.jvmargs=-Xss2m \
 	--additional-properties=launchDarklyApiVersion=${LATEST_API_VERSION}
-CODEGEN_PARAMS_javascript = \
-	-t $(TEMPLATES_PATH)/javascript \
-	--additional-properties=projectName=launchdarkly-api \
-	--additional-properties=projectVersion=$(TAG) \
-	--additional-properties=projectDescription="Build custom integrations with the LaunchDarkly REST API" \
-	--additional-properties=moduleName=LaunchDarklyApi
-CODEGEN_PARAMS_php = \
-	--additional-properties=packagePath=LaunchDarklyApi \
-	--additional-properties=composerVendorName=launchdarkly \
-	--additional-properties=composerProjectName=api-client-php \
-	--additional-properties=invokerPackage=LaunchDarklyApi \
-	--git-user-id=launchdarkly \
-	--git-repo-id=api-client-php
 CODEGEN_PARAMS_python = \
 	-t $(TEMPLATES_PATH)/python \
 	--additional-properties=packageName=launchdarkly_api \
@@ -114,13 +99,11 @@ CODEGEN_PARAMS_ruby = \
 	--additional-properties=launchDarklyApiVersion=${LATEST_API_VERSION}
 
 SAMPLE_FILE_go = main.go
-SAMPLE_FILE_javascript = index.js
 SAMPLE_FILE_python = main.py
 SAMPLE_FILE_ruby = main.rb
 SAMPLE_FILE_typescript-axios = index.ts
 
 SAMPLE_FORMAT_go = go
-SAMPLE_FORMAT_javascript = js
 SAMPLE_FORMAT_python = python
 SAMPLE_FORMAT_ruby = ruby
 SAMPLE_FORMAT_typescript-axios = ts

.ldrelease/config.yml

@@ -16,18 +16,4 @@ Server/client code for the API can be automatically generated. To generate the c
 
 ## How releases work
 
-This project is set up (via the files in `.ldrelease`) to work with LaunchDarkly's internal Releaser tool. Running a release via Releaser will execute the required `make` targets in the right order, sandboxed in a Docker container that contains all the necessary build tools. You can also do a "dry run" in Releaser, which does all of the _build_ steps and provides you with the build products, but does not push anything to GitHub or to package managers.
-
-That is the preferred way of doing releases, but the `make` targets can also be run locally if necessary, as long as your local environment has all of the necessary tools installed (as defined by the Docker image selected in `.ldrelease/config.yml` and anything else that's installed in `.ldrelease/prepare.sh`). Here are more details about what they do:
-
-* `make load_prior_targets`: Sets up the source repos for each client repository (such as `api-client-go`) as git submodules of the `targets` directory.
-* `make all`: Generates the API spec, runs the OpenAPI code generator to create the code for each API client, and copies the generated code into the submodules in `targets`.
-* `make build_clients`: Verifies that the generated code for each client can actually be built as a package. This runs the script for each client that is in `scripts/build`.
-* `make push`: Pushes the changes in the submodules to the client repositories.
-* `make push_dry_run`: Simulates what the result of `make push` would be.
-* `make publish`: Pushes the client code to package managers, for platforms where this is applicable (such as NPM for the JavaScript clients). This runs the script for each client that is in `scripts/release`, if any.
-* `make publish_dry_run`: Simulates what the result of `make publish` would be.This runs the script for each client that is in `scripts/build`, if any.
-
-Or, if you just want to look at the generated code locally, run `make targets_docker` which is equivalent to `make all` but uses a Docker container, so that the only tool you need to have installed locally is Docker. The output will appear in `./targets`. This is a convenient way to validate any local changes that relate to code generation. If you are also making changes that affect how the client code is packaged or published, it is better to use the slower but more comprehensive method of a Releaser dry run.
-
-When running any `make` targets locally, set the environment variable `$LD_RELEASE_VERSION` to the version you are releasing, such as "6.0.0". It is set automatically when releases are run through Releaser.
+This project is set up to use [Github Actions](https://github.com/launchdarkly/ld-openapi-private/actions/workflows/release.yml) to release new versions.